[MINOR] Avoid returning null in defaultUserApps when quota file does't config user
#786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallzhongfeng
changed the title
defaultUserAppsdefaultUserApps
smallzhongfeng
changed the title
defaultUserAppsdefaultUserApps when quota file does't config user
Codecov Report
@@ Coverage Diff @@
## master #786 +/- ##
============================================
+ Coverage 57.86% 59.31% +1.45%
Complexity 2028 2028
============================================
Files 298 284 -14
Lines 14520 12554 -1966
Branches 1185 1185
============================================
- Hits 8402 7447 -955
+ Misses 5643 4690 -953
+ Partials 475 417 -58
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
LGTM. I hadn't noticed this difference between |
zuston
approved these changes
Mar 31, 2023
|
Thanks @smallzhongfeng Merged. |
|
Thanks for your review! @zuston |
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
…pache#786) ### What changes were proposed in this pull request? `map.getOrDefault()` => `map.computeIfAbsent()` ### Why are the changes needed? If do not define the user and app num in the quota configuration file, it will appear that the `defaultUserApps` does not have the corresponding app number for this user, because we did not include the `quotaAppNum` in the `defaultUserApps`. **before** : The log from coordinator is `[ERROR] 2023-03-28 19:24:11,18 Grpc-260 AccessAppQuotaChecker check - Denied by AccessAppQuotaChecker => User: xxxx, current app num is: 3, default app num is: null.` **after** : The log from coordinator is `[ERROR] 2023-03-31 14:32:21,228 Grpc-240 AccessAppQuotaChecker check - Denied by AccessAppQuotaChecker => User: xxxx, current app num is: 3, default app num is: 3.` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs.
|
@smallzhongfeng There is a fix. It should be merged to branch 0.7. But there is conflicts with branch 0.7. Could you raise a pr to branch 0.7? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
map.getOrDefault()=>map.computeIfAbsent()Why are the changes needed?
If do not define the user and app num in the quota configuration file, it will appear that the
defaultUserAppsdoes not have the corresponding app number for this user, because we did not include thequotaAppNumin thedefaultUserApps.before :
The log from coordinator is
[ERROR] 2023-03-28 19:24:11,18 Grpc-260 AccessAppQuotaChecker check - Denied by AccessAppQuotaChecker => User: xxxx, current app num is: 3, default app num is: null.after :
The log from coordinator is
[ERROR] 2023-03-31 14:32:21,228 Grpc-240 AccessAppQuotaChecker check - Denied by AccessAppQuotaChecker => User: xxxx, current app num is: 3, default app num is: 3.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Origin uts.