Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#854][FOLLOWUP] feat(tez): Add Rss Input Class to begin Tez input task #949

Merged
merged 10 commits into from
Jun 25, 2023

Conversation

lifeSo
Copy link
Collaborator

@lifeSo lifeSo commented Jun 13, 2023

What changes were proposed in this pull request?

Add Rss Input Class to begin Tez input task

Why are the changes needed?

Fix: #854

Does this PR introduce any user-facing change?

No.

How was this patch tested?

unit test

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023

Codecov Report

Merging #949 (5dd52d7) into master (0e24225) will decrease coverage by 0.76%.
The diff coverage is 16.53%.

@@             Coverage Diff              @@
##             master     #949      +/-   ##
============================================
- Coverage     54.93%   54.17%   -0.76%     
- Complexity     2055     2477     +422     
============================================
  Files           327      355      +28     
  Lines         15203    17987    +2784     
  Branches       1174     1725     +551     
============================================
+ Hits           8352     9745    +1393     
- Misses         6382     7640    +1258     
- Partials        469      602     +133     
Impacted Files Coverage Δ
...rary/input/RssConcatenatedMergedKeyValueInput.java 0.00% <0.00%> (ø)
...ary/input/RssConcatenatedMergedKeyValuesInput.java 0.00% <0.00%> (ø)
...me/library/input/RssOrderedGroupedInputLegacy.java 0.00% <0.00%> (ø)
.../library/input/RssOrderedGroupedMergedKVInput.java 0.00% <0.00%> (ø)
...tez/runtime/library/input/RssUnorderedKVInput.java 0.00% <0.00%> (ø)
...untime/library/input/RssOrderedGroupedKVInput.java 46.02% <46.02%> (ø)

... and 69 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lifeSo
Copy link
Collaborator Author

lifeSo commented Jun 25, 2023

DaLao please see one see, is there any problems ?

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merged first.

@jerqi jerqi merged commit 60d9b21 into apache:master Jun 25, 2023
27 checks passed
@lifeSo
Copy link
Collaborator Author

lifeSo commented Jun 25, 2023

LGTM, merged first.

Thanks Dalao!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] [Tez] Tez Shuffle Read supporting RemoteShuffle
3 participants