Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[WEEX-482][Android] Added support for multi-value headers(WXStreamModule) #1300

Merged
merged 7 commits into from
Jan 7, 2019

Conversation

kuldeepkeshwar
Copy link
Contributor

@kuldeepkeshwar kuldeepkeshwar commented Jun 28, 2018

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@weex-bot
Copy link

weex-bot commented Jun 28, 2018

Fails
🚫 Failed to run assembleDebug task for android.
Messages
📖 android build verification finished.

Generated by 🚫 dangerJS

@kuldeepkeshwar kuldeepkeshwar changed the title Added support for multi-value headers(WXStreamModule) [WEEX-482][Android] Added support for multi-value headers(WXStreamModule) Jun 28, 2018
@gubaojian
Copy link
Member

gubaojian commented Jul 16, 2018

use git rebase -i to merge your multi commit history to one commit.

Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge later to avoid potential conflict

Copy link
Contributor

@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YorkShen YorkShen merged commit c7dd6c7 into apache:master Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants