From 2e0569ad5f2ae1ce153b932d87377d76d5ec1204 Mon Sep 17 00:00:00 2001 From: "LiuHongfeng(GuJian)" Date: Wed, 29 Mar 2017 10:39:46 +0800 Subject: [PATCH 1/2] *[iOS] bugfix:fix slider crash on iOS 8.x . --- .../WeexSDK/Sources/Component/WXSliderComponent.m | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/ios/sdk/WeexSDK/Sources/Component/WXSliderComponent.m b/ios/sdk/WeexSDK/Sources/Component/WXSliderComponent.m index 1df3aa2834..b16b13e5f7 100644 --- a/ios/sdk/WeexSDK/Sources/Component/WXSliderComponent.m +++ b/ios/sdk/WeexSDK/Sources/Component/WXSliderComponent.m @@ -284,6 +284,16 @@ - (BOOL)_isItemViewVisiable:(UIView *)itemView - (void)scrollViewDidScroll:(UIScrollView *)scrollView { + [NSObject cancelPreviousPerformRequestsWithTarget:self]; + __weak typeof(self) weakSelf = self; + if (!weakSelf) + { + //NSLog(@"self被销毁"); + return; + } + //ensure that the end of scroll is fired. + [self performSelector:@selector(scrollViewDidEndScrollingAnimation:) withObject:nil afterDelay:0.3]; + UIView *itemView = nil; for (itemView in self.itemViews) { if ([self _isItemViewVisiable:itemView]) { @@ -296,9 +306,6 @@ - (void)scrollViewDidScroll:(UIScrollView *)scrollView if (self.delegate && [self.delegate respondsToSelector:@selector(sliderView:sliderViewDidScroll:)]) { [self.delegate sliderView:self sliderViewDidScroll:self.scrollView]; } - [NSObject cancelPreviousPerformRequestsWithTarget:self]; - //ensure that the end of scroll is fired. - [self performSelector:@selector(scrollViewDidEndScrollingAnimation:) withObject:nil afterDelay:0.3]; } - (void)scrollViewWillBeginDragging:(UIScrollView *)scrollView From fe650884189be4ea36e005c4881207c3f3afb849 Mon Sep 17 00:00:00 2001 From: "LiuHongfeng(GuJian)" Date: Thu, 30 Mar 2017 10:16:35 +0800 Subject: [PATCH 2/2] *[iOS] fix: remove nslog code --- ios/sdk/WeexSDK/Sources/Component/WXSliderComponent.m | 1 - 1 file changed, 1 deletion(-) diff --git a/ios/sdk/WeexSDK/Sources/Component/WXSliderComponent.m b/ios/sdk/WeexSDK/Sources/Component/WXSliderComponent.m index b16b13e5f7..ff89d17b1d 100644 --- a/ios/sdk/WeexSDK/Sources/Component/WXSliderComponent.m +++ b/ios/sdk/WeexSDK/Sources/Component/WXSliderComponent.m @@ -288,7 +288,6 @@ - (void)scrollViewDidScroll:(UIScrollView *)scrollView __weak typeof(self) weakSelf = self; if (!weakSelf) { - //NSLog(@"self被销毁"); return; } //ensure that the end of scroll is fired.