Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

+ [android] fix wrong vertical offset on waterfall #424

Merged
merged 3 commits into from
Jun 15, 2017

Conversation

misakuo
Copy link
Member

@misakuo misakuo commented Jun 6, 2017

The RecyclerView#computeVerticalScrollOffset() will return wrong value when use StaggeredGridLayoutManager, add property stable to control calculated vertical offset using accumulative dy
Property stable only effective on android, and will not be public in the document

Reference: https://issues.apache.org/jira/browse/WEEX-39

@weex-bot
Copy link

weex-bot commented Jun 6, 2017

Fails
🚫 This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.
Warnings
⚠️ No Changelog changes!
⚠️ This PR should update related documents as well.
Messages
📖 According to the blame info, we recommended @xkli , @Rowandjj to be the reviewers.

Generated by 🚫 dangerJS

@sospartan
Copy link
Contributor

Pls create a JIRA issue about this. And rebase your branch will fix the travis error.

@misakuo
Copy link
Member Author

misakuo commented Jun 8, 2017

@sospartan done~

@sospartan
Copy link
Contributor

@misakuo Pls resolve the conflicting files here.

@misakuo
Copy link
Member Author

misakuo commented Jun 9, 2017

@sospartan completed ;)

@asfgit asfgit merged commit d35a927 into apache:0.14-dev Jun 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants