New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ [android] fix wrong vertical offset on waterfall #424

Merged
merged 3 commits into from Jun 15, 2017

Conversation

Projects
None yet
4 participants
@misakuo
Contributor

misakuo commented Jun 6, 2017

The RecyclerView#computeVerticalScrollOffset() will return wrong value when use StaggeredGridLayoutManager, add property stable to control calculated vertical offset using accumulative dy
Property stable only effective on android, and will not be public in the document

Reference: https://issues.apache.org/jira/browse/WEEX-39

@weex-bot

This comment has been minimized.

Show comment
Hide comment
@weex-bot

weex-bot Jun 6, 2017

Fails
🚫 This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.
Warnings
⚠️ No Changelog changes!
⚠️ This PR should update related documents as well.
Messages
📖 According to the blame info, we recommended @xkli , @Rowandjj to be the reviewers.

Generated by 🚫 dangerJS

weex-bot commented Jun 6, 2017

Fails
🚫 This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.
Warnings
⚠️ No Changelog changes!
⚠️ This PR should update related documents as well.
Messages
📖 According to the blame info, we recommended @xkli , @Rowandjj to be the reviewers.

Generated by 🚫 dangerJS

@sospartan

This comment has been minimized.

Show comment
Hide comment
@sospartan

sospartan Jun 7, 2017

Contributor

Pls create a JIRA issue about this. And rebase your branch will fix the travis error.

Contributor

sospartan commented Jun 7, 2017

Pls create a JIRA issue about this. And rebase your branch will fix the travis error.

@misakuo

This comment has been minimized.

Show comment
Hide comment
@misakuo

misakuo Jun 8, 2017

Contributor

@sospartan done~

Contributor

misakuo commented Jun 8, 2017

@sospartan done~

@sospartan

This comment has been minimized.

Show comment
Hide comment
@sospartan

sospartan Jun 9, 2017

Contributor

@misakuo Pls resolve the conflicting files here.

Contributor

sospartan commented Jun 9, 2017

@misakuo Pls resolve the conflicting files here.

@misakuo

This comment has been minimized.

Show comment
Hide comment
@misakuo

misakuo Jun 9, 2017

Contributor

@sospartan completed ;)

Contributor

misakuo commented Jun 9, 2017

@sospartan completed ;)

@asfgit asfgit merged commit d35a927 into apache:0.14-dev Jun 15, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment