From 95c7470f269ec82a4ae44d5a291672b565fcfa9b Mon Sep 17 00:00:00 2001 From: sospartan Date: Tue, 7 Mar 2017 11:35:30 +0800 Subject: [PATCH] * [android] fix loadmoreoffset value in scroller --- .../main/java/com/taobao/weex/ui/component/WXScroller.java | 4 ++-- .../com/taobao/weex/ui/component/list/BasicListComponent.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXScroller.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXScroller.java index 73aefdfa2e..1be3e3ea09 100755 --- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXScroller.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXScroller.java @@ -855,15 +855,15 @@ public void onScroll(WXScrollView scrollView, int x, int y) { protected void onLoadMore(WXScrollView scrollView, int x, int y) { try { String offset = getDomObject().getAttrs().getLoadMoreOffset(); - if (TextUtils.isEmpty(offset)) { return; } + int offsetInt = (int)WXViewUtils.getRealPxByWidth(Float.parseFloat(offset), WXSDKInstance.getViewPortWidth()); int contentH = scrollView.getChildAt(0).getHeight(); int scrollerH = scrollView.getHeight(); int offScreenY = contentH - y - scrollerH; - if (offScreenY < Integer.parseInt(offset)) { + if (offScreenY < offsetInt) { if (WXEnvironment.isApkDebugable()) { WXLogUtils.d("[WXScroller-onScroll] offScreenY :" + offScreenY); } diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java index 1f8732df69..a8aadb4e03 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java @@ -594,7 +594,7 @@ public void scrollTo(WXComponent component, Map options) { smooth = WXUtils.getBoolean(options.get(Constants.Name.ANIMATED), true); if (offsetStr != null) { try { - offsetFloat = WXViewUtils.getRealPxByWidth(Float.parseFloat(offsetStr), getInstance().getViewPortWidth()); + offsetFloat = WXViewUtils.getRealPxByWidth(Float.parseFloat(offsetStr), WXSDKInstance.getViewPortWidth()); }catch (Exception e ){ WXLogUtils.e("Float parseFloat error :"+e.getMessage()); }