From 594d8302cf14c65aa951ee15c5f916cab10bff33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=A1=8C=E4=B9=85?= Date: Fri, 11 Aug 2017 13:55:13 +0800 Subject: [PATCH 1/4] [html5] fix setItem cannot set value to 0 bug. https://aone.alibaba-inc.com/issue/12020693 --- html5/render/browser/extend/api/storage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/html5/render/browser/extend/api/storage.js b/html5/render/browser/extend/api/storage.js index a1d31be53b..3ae56990fa 100644 --- a/html5/render/browser/extend/api/storage.js +++ b/html5/render/browser/extend/api/storage.js @@ -41,7 +41,7 @@ const storage = { return } const sender = this.sender - if (!key || !value) { + if (!key || (!value && value != 0)) { sender.performCallback(callbackId, { result: 'failed', data: INVALID_PARAM From c1ae868bd055de2f1f25515cf1e0e79a335fe10a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=A1=8C=E4=B9=85?= Date: Fri, 11 Aug 2017 14:33:30 +0800 Subject: [PATCH 2/4] [html5] !== lint --- html5/render/browser/extend/api/storage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/html5/render/browser/extend/api/storage.js b/html5/render/browser/extend/api/storage.js index 3ae56990fa..ae76525d9a 100644 --- a/html5/render/browser/extend/api/storage.js +++ b/html5/render/browser/extend/api/storage.js @@ -41,7 +41,7 @@ const storage = { return } const sender = this.sender - if (!key || (!value && value != 0)) { + if (!key || (!value && value !== 0)) { sender.performCallback(callbackId, { result: 'failed', data: INVALID_PARAM From c01f87d130770f08b48361317a73b885fdfb030b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=A1=8C=E4=B9=85?= Date: Mon, 14 Aug 2017 14:20:48 +0800 Subject: [PATCH 3/4] [html5] commit update. and fire CI run again. @notdanger --- html5/render/browser/extend/api/storage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/html5/render/browser/extend/api/storage.js b/html5/render/browser/extend/api/storage.js index ae76525d9a..2188e5f3de 100644 --- a/html5/render/browser/extend/api/storage.js +++ b/html5/render/browser/extend/api/storage.js @@ -32,7 +32,7 @@ const storage = { * When passed a key name and value, will add that key to the storage, * or update that key's value if it already exists. * @param {string} key - * @param {string} value + * @param {string} value not null nor undifined，but 0 works * @param {function} callbackId */ setItem: function (key, value, callbackId) { From 3d38a24199465859ca46a3008e7c736d47025100 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=A1=8C=E4=B9=85?= Date: Thu, 17 Aug 2017 18:48:06 +0800 Subject: [PATCH 4/4] [html5] fire CI run again. @notdanger --- html5/render/browser/extend/api/storage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/html5/render/browser/extend/api/storage.js b/html5/render/browser/extend/api/storage.js index 2188e5f3de..bdd4c223bd 100644 --- a/html5/render/browser/extend/api/storage.js +++ b/html5/render/browser/extend/api/storage.js @@ -32,7 +32,7 @@ const storage = { * When passed a key name and value, will add that key to the storage, * or update that key's value if it already exists. * @param {string} key - * @param {string} value not null nor undifined，but 0 works + * @param {string} value not null nor undifined，but 0 works. * @param {function} callbackId */ setItem: function (key, value, callbackId) {