New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEX-183][jsfm] support append tree on root element #954

Merged
merged 1 commit into from Dec 28, 2017

Conversation

Projects
None yet
4 participants
@Hanks10100
Copy link
Contributor

Hanks10100 commented Dec 22, 2017

See this example: http://dotwe.org/vue/c479b4f8b2e7243efe1cfed2f442e35a

Even there is an append="tree" on the root element, js framework will send two render directives to native. JS Framework does it on purpose to ensure the performance of sending the first render directive (createBody). I think this feature is no longer needed.

@weex-bot

This comment has been minimized.

Copy link

weex-bot commented Dec 22, 2017

Messages
📖 android test finished.

Generated by 🚫 dangerJS

@Hanks10100 Hanks10100 force-pushed the Hanks10100:jsfm-feature-root-append-tree branch from 7b21112 to 9afc4d5 Dec 22, 2017

@asfgit asfgit merged commit 9afc4d5 into apache:master Dec 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

asfgit pushed a commit that referenced this pull request Dec 28, 2017

@Hanks10100 Hanks10100 deleted the Hanks10100:jsfm-feature-root-append-tree branch Dec 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment