From 400a7dc351bbe3456b718e1b7412cce47c20a6d8 Mon Sep 17 00:00:00 2001 From: Damien Corneau Date: Thu, 24 Sep 2015 17:36:36 +0900 Subject: [PATCH 01/12] Split Chart Selector and Paragraph Controls --- .../paragraph/paragraph-chart-selector.html | 29 ++++ .../notebook/paragraph/paragraph-control.html | 76 +++++++++++ .../src/app/notebook/paragraph/paragraph.html | 128 +----------------- 3 files changed, 110 insertions(+), 123 deletions(-) create mode 100644 zeppelin-web/src/app/notebook/paragraph/paragraph-chart-selector.html create mode 100644 zeppelin-web/src/app/notebook/paragraph/paragraph-control.html diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph-chart-selector.html b/zeppelin-web/src/app/notebook/paragraph/paragraph-chart-selector.html new file mode 100644 index 00000000000..a81ca53598f --- /dev/null +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph-chart-selector.html @@ -0,0 +1,29 @@ +
+ + + + + + +
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph-control.html b/zeppelin-web/src/app/notebook/paragraph/paragraph-control.html new file mode 100644 index 00000000000..d9cd3f2a7b8 --- /dev/null +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph-control.html @@ -0,0 +1,76 @@ +
+ + + {{paragraph.status}} + + + + {{getProgress()}}% + + + + + + + + + + + + +
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.html b/zeppelin-web/src/app/notebook/paragraph/paragraph.html index cded6d8ea31..f7ace136995 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.html +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.html @@ -90,15 +90,7 @@ ng-model="paragraph.settings.params[formulaire.name]" ng-class="{'disable': paragraph.status == 'RUNNING' || paragraph.status == 'PENDING' }" name="{{formulaire.name}}" - ng-options="option.value as (option.displayName||option.value) for option in paragraph.settings.forms[formulaire.name].options" - > - + ng-options="option.value as (option.displayName||option.value) for option in paragraph.settings.forms[formulaire.name].options"> @@ -106,44 +98,11 @@
-
- - - - - - -
+
- - settings - - - settings + + settings @@ -315,7 +274,6 @@
- @@ -402,86 +360,10 @@ -
- - - {{paragraph.status}} - - - - {{getProgress()}}% - - - - - - - - - - - - -
+
- From 09578fd84248d7d8b9c55841d07c228ad47257a6 Mon Sep 17 00:00:00 2001 From: Damien Corneau Date: Fri, 25 Sep 2015 17:21:01 +0900 Subject: [PATCH 02/12] Separate progress Bar --- .../paragraph/paragraph-chart-selector.html | 6 ++++ .../paragraph/paragraph-progressBar.html | 8 +++++ .../src/app/notebook/paragraph/paragraph.css | 2 +- .../src/app/notebook/paragraph/paragraph.html | 30 +++---------------- 4 files changed, 19 insertions(+), 27 deletions(-) create mode 100644 zeppelin-web/src/app/notebook/paragraph/paragraph-progressBar.html diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph-chart-selector.html b/zeppelin-web/src/app/notebook/paragraph/paragraph-chart-selector.html index a81ca53598f..e293f81691b 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph-chart-selector.html +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph-chart-selector.html @@ -27,3 +27,9 @@ ng-click="setGraphMode('scatterChart', true)"> + + + settings + + diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph-progressBar.html b/zeppelin-web/src/app/notebook/paragraph/paragraph-progressBar.html new file mode 100644 index 00000000000..2329487c3fb --- /dev/null +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph-progressBar.html @@ -0,0 +1,8 @@ +
+
+
+
+
+
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.css b/zeppelin-web/src/app/notebook/paragraph/paragraph.css index 6e370ddc1b9..4ac27962b85 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.css +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.css @@ -142,7 +142,7 @@ font-size: 1px; color: #AAAAAA; height:4px; - margin: 1px 0 0 0; + margin: 0px 0px 3px 0px; } .paragraph .runControl .progress { diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.html b/zeppelin-web/src/app/notebook/paragraph/paragraph.html index f7ace136995..a9534464537 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.html +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.html @@ -35,7 +35,7 @@
-
+
-
-
-
-
- -
-
-
-
-
- {{getProgress()}}% -
-
-
+
- + name="{{formulaire.name}}" /> +

{{note.name || 'Note ' + note.id}}

+ + + + + + + + + + + +
+ + +
+
+ +
+ + + + + + + + + + + +
+ +
diff --git a/zeppelin-web/src/app/notebook/notebook.html b/zeppelin-web/src/app/notebook/notebook.html index 9679ac5a4fb..227f8cdaafc 100644 --- a/zeppelin-web/src/app/notebook/notebook.html +++ b/zeppelin-web/src/app/notebook/notebook.html @@ -12,129 +12,7 @@ limitations under the License. --> -
-

- -

{{note.name || 'Note ' + note.id}}

- - - - - - - - - - - -
- - -
-
- -
- - - - - - - - - - - -
-

-
- +
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph-graph.html b/zeppelin-web/src/app/notebook/paragraph/paragraph-graph.html new file mode 100644 index 00000000000..56d35c46cae --- /dev/null +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph-graph.html @@ -0,0 +1,42 @@ +
+ +
+
+ +
+ +
+ +
+ +
+ +
+ +
+ +
+ +
+ +
+ +
+ +
+ +
+
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph-graphOptions.html b/zeppelin-web/src/app/notebook/paragraph/paragraph-graphOptions.html new file mode 100644 index 00000000000..ec6edcffcc7 --- /dev/null +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph-graphOptions.html @@ -0,0 +1,18 @@ +
+
+ +
+ + +
+
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph-parameterizedQueryForm.html b/zeppelin-web/src/app/notebook/paragraph/paragraph-parameterizedQueryForm.html new file mode 100644 index 00000000000..c35219c3a1b --- /dev/null +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph-parameterizedQueryForm.html @@ -0,0 +1,27 @@ + +
+ +
+ + + + +
+
+ diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph-pivot.html b/zeppelin-web/src/app/notebook/paragraph/paragraph-pivot.html new file mode 100644 index 00000000000..cc229c29a0b --- /dev/null +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph-pivot.html @@ -0,0 +1,155 @@ +
+ +
+ + All fields: +
+
    +
  • +
    + {{col.name | limitTo: 30}}{{col.name.length > 30 ? '...' : ''}} +
    +
  • +
+
+ +
+
+ + Keys +
    +
  • +
    + {{item.name}} +
    +
  • +
+
+
+
+ + Groups +
    +
  • +
    + {{item.name}} +
    +
  • +
+
+
+
+ + Values +
    +
  • +
    + + +
    +
  • +
+
+
+
+ +
+
+ + xAxis +
    +
  • +
    + {{paragraph.config.graph.scatter.xAxis.name}} +
    +
  • +
+
+
+
+ + yAxis +
    +
  • +
    + {{paragraph.config.graph.scatter.yAxis.name}} +
    +
  • +
+
+
+
+ + group +
    +
  • +
    + {{paragraph.config.graph.scatter.group.name}} +
    +
  • +
+
+
+
+ + size + +
    +
  • +
    + {{paragraph.config.graph.scatter.size.name}} +
    +
  • +
+
+
+
+
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph-results.html b/zeppelin-web/src/app/notebook/paragraph/paragraph-results.html new file mode 100644 index 00000000000..323fd9ca057 --- /dev/null +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph-results.html @@ -0,0 +1,39 @@ +
+ +
+
+ +
+
+ +
+
+ +
+
+ + + + +
+
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.html b/zeppelin-web/src/app/notebook/paragraph/paragraph.html index a9534464537..043b6e81739 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.html +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.html @@ -51,297 +51,22 @@
- -
-
- -
- - - - -
-
-
+
- -
-
- -
- - -
- - All fields: -
-
    -
  • -
    - {{col.name | limitTo: 30}}{{col.name.length > 30 ? '...' : ''}} -
    -
  • -
-
- -
-
- - Keys -
    -
  • -
    - {{item.name}} -
    -
  • -
-
-
-
- - Groups -
    -
  • -
    - {{item.name}} -
    -
  • -
-
-
-
- - Values -
    -
  • -
    - - -
    -
  • -
-
-
-
- -
-
- - xAxis -
    -
  • -
    - {{paragraph.config.graph.scatter.xAxis.name}} -
    -
  • -
-
-
-
- - yAxis -
    -
  • -
    - {{paragraph.config.graph.scatter.yAxis.name}} -
    -
  • -
-
-
-
- - group -
    -
  • -
    - {{paragraph.config.graph.scatter.group.name}} -
    -
  • -
-
-
-
- - size - -
    -
  • -
    - {{paragraph.config.graph.scatter.size.name}} -
    -
  • -
-
-
-
-
- - -
- -
-
- -
- -
- -
- -
- -
- -
- -
- -
- -
- -
- -
- -
-
- -
-
- -
-
- -
-
- -
-
- - - - -
-
+
+
-
+
From ebdf0bd3362530a14b6c4bde927fd7bf6d0b4743 Mon Sep 17 00:00:00 2001 From: Damien CORNEAU Date: Thu, 3 Dec 2015 17:56:40 +0900 Subject: [PATCH 08/12] Fix ActionBar Z-index after rebase broke it --- zeppelin-web/src/assets/styles/looknfeel/default.css | 1 - 1 file changed, 1 deletion(-) diff --git a/zeppelin-web/src/assets/styles/looknfeel/default.css b/zeppelin-web/src/assets/styles/looknfeel/default.css index 10403a430e7..93d302aa21c 100644 --- a/zeppelin-web/src/assets/styles/looknfeel/default.css +++ b/zeppelin-web/src/assets/styles/looknfeel/default.css @@ -20,7 +20,6 @@ body { box-shadow: 0 2px 4px rgba(0, 0, 0, 0.15); color: #2c3e50; border-bottom: 1px solid #E5E5E5; - z-index: 300; } .editor, From 6d628521833b134d1abb10be2cae90b6ff39f1a7 Mon Sep 17 00:00:00 2001 From: Damien CORNEAU Date: Thu, 3 Dec 2015 18:40:13 +0900 Subject: [PATCH 09/12] Fix Empty HTML result when slow page loading --- .../src/app/notebook/paragraph/paragraph-results.html | 9 ++------- .../src/app/notebook/paragraph/paragraph.controller.js | 5 ++--- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph-results.html b/zeppelin-web/src/app/notebook/paragraph/paragraph-results.html index 323fd9ca057..e3929143c35 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph-results.html +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph-results.html @@ -3,32 +3,27 @@
+ ng-if="paragraph.result.type == 'HTML'">
+ ng-if="paragraph.result.type == 'ANGULAR'">
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js index 5aff815da09..1a91c2760a2 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js @@ -67,10 +67,10 @@ angular.module('zeppelinWebApp') console.log('HTML rendering error %o', err); } } else { + $timeout(retryRenderer, 10); } }; $timeout(retryRenderer); - }; $scope.renderAngular = function() { @@ -84,11 +84,10 @@ angular.module('zeppelinWebApp') console.log('ANGULAR rendering error %o', err); } } else { - $timeout(retryRenderer,10); + $timeout(retryRenderer, 10); } }; $timeout(retryRenderer); - }; From 69ac2c6bb444c9315ed8ae684a82b8de79851c0d Mon Sep 17 00:00:00 2001 From: Damien CORNEAU Date: Thu, 3 Dec 2015 18:45:44 +0900 Subject: [PATCH 10/12] Add Header on new files --- .../src/app/notebook/paragraph/paragraph-graph.html | 13 +++++++++++++ .../notebook/paragraph/paragraph-graphOptions.html | 13 +++++++++++++ .../paragraph/paragraph-parameterizedQueryForm.html | 13 +++++++++++++ .../src/app/notebook/paragraph/paragraph-pivot.html | 13 +++++++++++++ .../app/notebook/paragraph/paragraph-results.html | 13 +++++++++++++ 5 files changed, 65 insertions(+) diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph-graph.html b/zeppelin-web/src/app/notebook/paragraph/paragraph-graph.html index 56d35c46cae..e72ad0e049a 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph-graph.html +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph-graph.html @@ -1,3 +1,16 @@ +