From 9ced186f4a0513c3fe5654295db564e8c77d0a2f Mon Sep 17 00:00:00 2001 From: Ryu Ah young Date: Tue, 19 Jan 2016 14:14:19 +0900 Subject: [PATCH 1/3] Add some information about how we can review and test PR --- CONTRIBUTING.md | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e18ea1b88a2..d49bfa883d3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -39,6 +39,29 @@ You can also use this small bookmarklet tool to fill your Pull Request fields au javascript:(function() {var e = document.getElementById('pull_request_body');if (e) {e.value += '### What is this PR for?\nA few sentences describing the overall goals of the pull request\'s commits.\n\n### What type of PR is it?\n[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]\n\n### Todos\n* [ ] - Task\n\n### Is there a relevant Jira issue?\n\n### How should this be tested?\nOutline the steps to test the PR here.\n\n### Screenshots (if appropriate)\n\n### Questions:\n* Does the licenses files need update?\n* Is there breaking changes for older versions?\n* Does this needs documentation?';}})(); ``` +## Testing a Pull Request +You can also test and review a particular Pull Request. Here are two useful ways. + +* Using a utility provided from Zeppelin. + + ``` + dev/test_zeppelin_pr.py [# of PR] + ``` + + For example, if you want to test `#513`, then the command will be like: + + ``` + dev/test_zeppelin_pr.py 513 + ``` + +* Another way is using [github/hub](https://github.com/github/hub). + + ``` + hub checkout https://github.com/apache/incubator-zeppelin/pull/[# of PR] + ``` + +The above two methods will help you to test and review the Pull Request. + ## Source Control Workflow Zeppelin follows [Fork & Pull] (https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/Development-workflow-with-Git:-Fork,-Branching,-Commits,-and-Pull-Request) model. @@ -53,7 +76,6 @@ When a Pull Request is submitted, it is being merged or rejected by following re * Committer can initiate lazy consensus ("Merge if there is no more discussion") and the code can be merged after certain time (normally 24 hours) when there is no review exists. * Contributor can ping reviewers (including committer) by commenting 'Ready to review' or suitable indication. - ## Becoming a Committer The PPMC adds new committers from the active contributors, based on their contribution to Zeppelin. The qualifications for new committers include: From 378155054aa3ab0e8a5b1a98a5b8543e5af2b730 Mon Sep 17 00:00:00 2001 From: Ryu Ah young Date: Tue, 19 Jan 2016 15:44:24 +0900 Subject: [PATCH 2/3] Delete 'like' --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d49bfa883d3..ee522081433 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -48,7 +48,7 @@ You can also test and review a particular Pull Request. Here are two useful ways dev/test_zeppelin_pr.py [# of PR] ``` - For example, if you want to test `#513`, then the command will be like: + For example, if you want to test `#513`, then the command will be: ``` dev/test_zeppelin_pr.py 513 From 5f370d56e7665e38f5e78a9ace73525dff072235 Mon Sep 17 00:00:00 2001 From: Ryu Ah young Date: Wed, 20 Jan 2016 15:38:31 +0900 Subject: [PATCH 3/3] Fix some grammar errors --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ee522081433..f40e808691e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -60,7 +60,7 @@ You can also test and review a particular Pull Request. Here are two useful ways hub checkout https://github.com/apache/incubator-zeppelin/pull/[# of PR] ``` -The above two methods will help you to test and review the Pull Request. +The above two methods will help you test and review Pull Requests. ## Source Control Workflow Zeppelin follows [Fork & Pull] (https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/Development-workflow-with-Git:-Fork,-Branching,-Commits,-and-Pull-Request) model.