From ae04b028849b5e347fc562872fdb7d330e16e4ce Mon Sep 17 00:00:00 2001 From: healzhou Date: Fri, 9 Jul 2021 21:40:33 +0800 Subject: [PATCH] [INLONG-696] modify the status of the entities after approval --- .../common/enums/BizErrorCodeEnum.java | 5 -- .../manager/common/enums/EntityStatus.java | 76 +++++++------------ .../datastorage/BaseStorageClusterInfo.java | 34 --------- inlong-manager/manager-dao/pom.xml | 14 ++++ .../dao/mapper/DataStreamEntityMapper.java | 3 + .../mappers/DataStreamEntityMapper.xml | 13 +++- .../mappers/StorageHiveEntityMapper.xml | 6 +- inlong-manager/manager-service/pom.xml | 19 +++++ .../manager/service/core/BusinessService.java | 2 +- .../service/core/DataStreamService.java | 12 +++ .../core/impl/BusinessProcessOperation.java | 2 +- .../core/impl/BusinessServiceImpl.java | 26 +++---- .../core/impl/DataStreamServiceImpl.java | 19 ++++- .../core/impl/StorageHiveOperation.java | 2 +- .../service/core/impl/StorageServiceImpl.java | 4 +- .../thirdpart/hive/HiveTableOperator.java | 7 +- .../PushHiveConfigToSortEventListener.java | 52 +++++++------ .../CreateResourceWorkflowDefinition.java | 20 ++--- .../newbusiness/NewBusinessApproveForm.java | 14 ++-- .../NewBusinessWorkflowDefinition.java | 22 +++--- ...java => ApproveCancelProcessListener.java} | 4 +- ...ener.java => ApprovePassTaskListener.java} | 10 +-- ...java => ApproveRejectProcessListener.java} | 4 +- .../listener/CompleteProcessListener.java | 66 ---------------- ...CreateResourceCompleteProcessListener.java | 14 +++- .../CreateResourceFailedProcessListener.java | 9 ++- .../NewConsumptionWorkflowDefinition.java | 24 +++--- ...va => ConsumptionApproveTaskListener.java} | 2 +- ... => ConsumptionCancelProcessListener.java} | 4 +- ...> ConsumptionCompleteProcessListener.java} | 2 +- ... => ConsumptionRejectProcessListener.java} | 12 +-- .../SingleStreamCompleteProcessListener.java | 13 +++- .../SingleStreamFailedProcessListener.java | 14 +++- .../workflow/core/TransactionHelper.java | 11 +-- inlong-manager/pom.xml | 6 ++ 35 files changed, 258 insertions(+), 289 deletions(-) delete mode 100644 inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/datastorage/BaseStorageClusterInfo.java rename inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/newbusiness/listener/{CancelProcessListener.java => ApproveCancelProcessListener.java} (95%) rename inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/newbusiness/listener/{ApproveTaskListener.java => ApprovePassTaskListener.java} (97%) rename inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/newbusiness/listener/{RejectProcessListener.java => ApproveRejectProcessListener.java} (95%) delete mode 100644 inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/newbusiness/listener/CompleteProcessListener.java rename inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/newconsumption/listener/{ApproveTaskEventListener.java => ConsumptionApproveTaskListener.java} (97%) rename inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/newconsumption/listener/{CancelProcessEventListener.java => ConsumptionCancelProcessListener.java} (93%) rename inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/newconsumption/listener/{CompleteProcessEventListener.java => ConsumptionCompleteProcessListener.java} (98%) rename inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/newconsumption/listener/{RejectProcessEventListener.java => ConsumptionRejectProcessListener.java} (92%) diff --git a/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/BizErrorCodeEnum.java b/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/BizErrorCodeEnum.java index 308497117e4..09556648f4d 100644 --- a/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/BizErrorCodeEnum.java +++ b/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/BizErrorCodeEnum.java @@ -38,7 +38,6 @@ public enum BizErrorCodeEnum { CLUSTER_NOT_FOUND(1101, "Cluster information does not exist"), - DATA_STREAM_NOT_FOUND(1201, "Data stream does not exist/no operation permission"), DATA_STREAM_ID_DUPLICATE(1202, "The current business has a data stream with the same ID"), DATA_STREAM_OPT_NOT_ALLOWED(1203, @@ -72,10 +71,6 @@ public enum BizErrorCodeEnum { STORAGE_HIVE_FIELD_SAVE_FAILED(1404, "Failed to save/update HIVE data storage field"), STORAGE_OPT_NOT_ALLOWED(1405, "The current business status does not allow adding/modifying/deleting data storage information"), - STORAGE_CLUSTER_UPDATE_NOT_ALLOWED(1406, - "Current business status does not allow modification of storage cluster information"), - STORAGE_APP_GROUP_UPDATE_NOT_ALLOWED(1407, - "Current business status does not allow modification of storage application group information"), STORAGE_DB_NAME_UPDATE_NOT_ALLOWED(1408, "The current business status does not allow modification of the storage target database name"), STORAGE_TB_NAME_UPDATE_NOT_ALLOWED(1409, diff --git a/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/EntityStatus.java b/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/EntityStatus.java index 3a2dce0eac6..fb3ed22c4da 100644 --- a/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/EntityStatus.java +++ b/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/EntityStatus.java @@ -36,25 +36,25 @@ public enum EntityStatus { DELETED(40, "deleted"), // Business related status - BIZ_WAIT_APPLYING(100, "waiting to applying"), - BIZ_WAIT_APPROVE(101, "waiting to approve"), - BIZ_APPROVE_REJECT(102, "approval reject"), - BIZ_APPROVE_PASS(103, "approval pass"), - BIZ_CONFIG_ING(110, "configuring"), - BIZ_CONFIG_FAILURE(120, "failed to config"), - BIZ_CONFIG_SUCCESS(130, "successfully config"), + BIZ_WAIT_SUBMIT(100, "waiting for submit"), + BIZ_WAIT_APPROVAL(101, "waiting for approval"), + BIZ_APPROVE_REJECTED(102, "approval rejected"), + BIZ_APPROVE_PASSED(103, "approval passed"), + BIZ_CONFIG_ING(110, "in configure"), + BIZ_CONFIG_FAILED(120, "configuration failed"), + BIZ_CONFIG_SUCCESSFUL(130, "configuration successful"), // Data stream related status DATA_STREAM_NEW(100, "new"), - DATA_STREAM_CONFIG_ING(110, "configuring"), - DATA_STREAM_CONFIG_FAILURE(120, "failed to config"), - DATA_STREAM_CONFIG_SUCCESS(130, "successfully config"), + DATA_STREAM_CONFIG_ING(110, "in configure"), + DATA_STREAM_CONFIG_FAILED(120, "configuration failed"), + DATA_STREAM_CONFIG_SUCCESSFUL(130, "configuration successful"), // Data storage related status DATA_STORAGE_NEW(100, "new"), - DATA_STORAGE_CONFIG_ING(110, "configuring"), - DATA_STORAGE_CONFIG_FAILURE(120, "failed to config"), - DATA_STORAGE_CONFIG_SUCCESS(130, "successfully config"), + DATA_STORAGE_CONFIG_ING(110, "in configure"), + DATA_STORAGE_CONFIG_FAILED(120, "configuration failed"), + DATA_STORAGE_CONFIG_SUCCESSFUL(130, "configuration successful"), // Data source related status DATA_RESOURCE_NEW(200, "new"), @@ -67,69 +67,51 @@ public enum EntityStatus { AGENT_WAIT_DELETE(204, "wait delete"), AGENT_WAIT_UPDATE(205, "wait update"), - AGENT_ISSUED_CREATE(300, "created and issued"), - AGENT_ISSUED_STOP(302, "stop has been issued"), - AGENT_ISSUED_START(303, "start has been issued"), - AGENT_ISSUED_DELETE(304, "deletion has been issued"), - AGENT_ISSUED_UPDATE(305, "modification has been issued"), - - DEPLOY_WAIT(311, "waiting to change deployment"), - DEPLOY_ING(312, "deploying"), - DEPLOY_FAILURE(313, "deployment failed"), - DEPLOY_SUCCESS(314, "deployed successfully"), - - ISSUE_WAIT(321, "waiting to issue"), - ISSUE_ING(322, "issuing"), - ISSUE_FAILURE(323, "failed to issue"), - ISSUE_SUCCESS(324, "successfully issued"), ; /** * The status of the business that can initiate the approval process: - *

[BIZ_WAIT_APPLYING] [BIZ_APPROVE_REJECT] [BIZ_CONFIG_FAILURE] [BIZ_CONFIG_SUCCESS] + *

[BIZ_WAIT_SUBMIT] [BIZ_APPROVE_REJECTED] [BIZ_CONFIG_FAILED] [BIZ_CONFIG_SUCCESSFUL] */ public static final List ALLOW_START_WORKFLOW_STATUS = Arrays.asList( - BIZ_WAIT_APPLYING.getCode(), BIZ_APPROVE_REJECT.getCode(), BIZ_CONFIG_FAILURE.getCode(), - BIZ_CONFIG_SUCCESS.getCode()); + BIZ_WAIT_SUBMIT.getCode(), BIZ_APPROVE_REJECTED.getCode(), BIZ_CONFIG_FAILED.getCode(), + BIZ_CONFIG_SUCCESSFUL.getCode()); /** * The status of the business that can be modified: - *

[DRAFT] [BIZ_WAIT_APPLYING] [BIZ_APPROVE_REJECT] [BIZ_CONFIG_FAILURE] [BIZ_CONFIG_SUCCESS] + *

[DRAFT] [BIZ_WAIT_SUBMIT] [BIZ_APPROVE_REJECTED] [BIZ_CONFIG_FAILED] [BIZ_CONFIG_SUCCESSFUL] *

[BIZ_CONFIG_ING] status cannot be modified */ public static final List ALLOW_UPDATE_BIZ_STATUS = Arrays.asList( - DRAFT.getCode(), BIZ_WAIT_APPLYING.getCode(), BIZ_APPROVE_REJECT.getCode(), - BIZ_CONFIG_FAILURE.getCode(), BIZ_CONFIG_SUCCESS.getCode()); + DRAFT.getCode(), BIZ_WAIT_SUBMIT.getCode(), BIZ_APPROVE_REJECTED.getCode(), + BIZ_CONFIG_FAILED.getCode(), BIZ_CONFIG_SUCCESSFUL.getCode()); /** - * The status of the service that can be deleted: - *

[DRAFT] [BIZ_WAIT_APPLYING] [BIZ_APPROVE_REJECT] [BIZ_CONFIG_FAILURE] [BIZ_CONFIG_SUCCESS] - *

[BIZ_CONFIG_FAILURE] [BIZ_CONFIG_SUCCESS] status cannot be deleted + * The status of the service that can be deleted - all status + *

[DRAFT] [BIZ_WAIT_SUBMIT] [BIZ_APPROVE_REJECTED] [BIZ_CONFIG_ING] [BIZ_CONFIG_FAILED] [BIZ_CONFIG_SUCCESSFUL] + *

[BIZ_WAIT_APPROVAL] [BIZ_APPROVE_PASSED] status cannot be deleted */ public static final List ALLOW_DELETE_BIZ_STATUS = Arrays.asList( - DRAFT.getCode(), BIZ_WAIT_APPLYING.getCode(), BIZ_APPROVE_REJECT.getCode(), - BIZ_CONFIG_FAILURE.getCode(), BIZ_CONFIG_SUCCESS.getCode()); + DRAFT.getCode(), BIZ_WAIT_SUBMIT.getCode(), BIZ_APPROVE_REJECTED.getCode(), + BIZ_CONFIG_ING.getCode(), BIZ_CONFIG_FAILED.getCode(), BIZ_CONFIG_SUCCESSFUL.getCode()); /** * The business can cascade to delete the status of the associated data: - *

[DRAFT] [BIZ_WAIT_APPLYING] */ public static final List ALLOW_DELETE_BIZ_CASCADE_STATUS = Arrays.asList( - DRAFT.getCode(), BIZ_WAIT_APPLYING.getCode()); + DRAFT.getCode(), BIZ_WAIT_SUBMIT.getCode()); /** - * Status of business approval: - *

[BIZ_CONFIG_FAILURE] [BIZ_CONFIG_SUCCESS] + * Status of business approval */ public static final List BIZ_APPROVE_PASS_STATUS = Arrays.asList( - BIZ_CONFIG_FAILURE.getCode(), BIZ_CONFIG_SUCCESS.getCode()); + BIZ_CONFIG_FAILED.getCode(), BIZ_CONFIG_SUCCESSFUL.getCode()); /** - * Temporary business status, adding, deleting and modifying operations are not allowed: - *

[BIZ_WAIT_APPROVE] [BIZ_CONFIG_ING] + * Temporary business status, adding, deleting and modifying operations are not allowed */ public static final List BIZ_TEMP_STATUS = Arrays.asList( - BIZ_WAIT_APPROVE.getCode(), BIZ_CONFIG_ING.getCode()); + BIZ_WAIT_APPROVAL.getCode(), BIZ_CONFIG_ING.getCode()); private final Integer code; private final String description; diff --git a/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/datastorage/BaseStorageClusterInfo.java b/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/datastorage/BaseStorageClusterInfo.java deleted file mode 100644 index 225cc3bf7ee..00000000000 --- a/inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/datastorage/BaseStorageClusterInfo.java +++ /dev/null @@ -1,34 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.inlong.manager.common.pojo.datastorage; - -import io.swagger.annotations.ApiModelProperty; -import lombok.Data; - -/** - * Basic cluster information - */ -@Data -public class BaseStorageClusterInfo { - - private Integer id; - - @ApiModelProperty("Cluster name") - private String name; - -} diff --git a/inlong-manager/manager-dao/pom.xml b/inlong-manager/manager-dao/pom.xml index 56c46fcab22..52d774e922d 100644 --- a/inlong-manager/manager-dao/pom.xml +++ b/inlong-manager/manager-dao/pom.xml @@ -129,6 +129,20 @@ + + org.apache.hive + hive-exec + + + hive-llap-tez + org.apache.hive + + + hive-vector-code-gen + org.apache.hive + + + diff --git a/inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/DataStreamEntityMapper.java b/inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/DataStreamEntityMapper.java index e50a3d863dc..7e74009d703 100644 --- a/inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/DataStreamEntityMapper.java +++ b/inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/DataStreamEntityMapper.java @@ -80,4 +80,7 @@ DataStreamInfoToHiveConfig queryStreamToHiveBaseInfoByIdentifier(@Param("bid") S */ int deleteAllByBid(@Param("bid") String bid); + int updateStatusByIdentifier(@Param("bid") String bid, @Param("dsid") String dsid, @Param("status") Integer status, + @Param("modifier") String modifier); + } \ No newline at end of file diff --git a/inlong-manager/manager-dao/src/main/resources/mappers/DataStreamEntityMapper.xml b/inlong-manager/manager-dao/src/main/resources/mappers/DataStreamEntityMapper.xml index 24e7b0bee1a..064f84545e9 100644 --- a/inlong-manager/manager-dao/src/main/resources/mappers/DataStreamEntityMapper.xml +++ b/inlong-manager/manager-dao/src/main/resources/mappers/DataStreamEntityMapper.xml @@ -44,7 +44,7 @@ + type="org.apache.inlong.manager.common.pojo.datastream.DataStreamInfoToHiveConfig"> @@ -493,6 +493,17 @@ and data_stream_identifier = #{dataStreamIdentifier, jdbcType=VARCHAR} and is_deleted = 0 + + update data_stream + set status = #{status, jdbcType=INTEGER}, modifier = #{modifier, jdbcType=VARCHAR} + + business_identifier = #{bid, jdbcType=VARCHAR} + + and data_stream_identifier = #{dsid, jdbcType=VARCHAR} + + and is_deleted = 0 + +