-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Pipe: Fix NullPointerException in concurrent event access #16849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f22104 to
ec59808
Compare
Caideyipi
reviewed
Dec 3, 2025
...in/java/org/apache/iotdb/db/pipe/event/common/tablet/PipeInsertNodeTabletInsertionEvent.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Better remove the stack printed at "ignored because the failure event is released", just use e.getMessage() or null if e == null |
Caideyipi
reviewed
Dec 3, 2025
...in/java/org/apache/iotdb/db/pipe/event/common/tablet/PipeInsertNodeTabletInsertionEvent.java
Outdated
Show resolved
Hide resolved
Caideyipi
reviewed
Dec 3, 2025
...in/java/org/apache/iotdb/db/pipe/event/common/tablet/PipeInsertNodeTabletInsertionEvent.java
Outdated
Show resolved
Hide resolved
Caideyipi
reviewed
Dec 3, 2025
...in/java/org/apache/iotdb/db/pipe/event/common/tablet/PipeInsertNodeTabletInsertionEvent.java
Outdated
Show resolved
Hide resolved
Caideyipi
reviewed
Dec 3, 2025
...in/java/org/apache/iotdb/db/pipe/event/common/tablet/PipeInsertNodeTabletInsertionEvent.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/iotdb/db/pipe/event/common/tablet/PipeInsertNodeTabletInsertionEvent.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/iotdb/db/pipe/event/common/tablet/PipeInsertNodeTabletInsertionEvent.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/iotdb/db/pipe/event/common/tablet/PipeInsertNodeTabletInsertionEvent.java
Outdated
Show resolved
Hide resolved
Caideyipi
approved these changes
Dec 3, 2025
Collaborator
Caideyipi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jt2594838
approved these changes
Dec 3, 2025
luoluoyuyu
added a commit
to luoluoyuyu/iotdb
that referenced
this pull request
Dec 5, 2025
* fix * fix * fix * fix * fix (cherry picked from commit 5bc4779)
jt2594838
pushed a commit
that referenced
this pull request
Dec 5, 2025
JackieTien97
pushed a commit
that referenced
this pull request
Dec 8, 2025
* fix * fix * fix * fix * fix (cherry picked from commit 5bc4779)
JackieTien97
pushed a commit
that referenced
this pull request
Dec 9, 2025
* fix * fix * fix * fix * fix (cherry picked from commit 5bc4779)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix NullPointerException caused by concurrent access to insertNode field in pipe transfer.
Root Cause:
Changes:
Fixed methods in PipeInsertNodeTabletInsertionEvent:
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR