Pipe: Prevent duplicate error logging in AsyncPipeDataTransferServiceClient #16856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient - Change printLogWhenEncounterException from final to mutable field - Set printLogWhenEncounterException to false in onError() to avoid repeated error logs - This prevents flooding logs when client encounters errors
jt2594838
approved these changes
Dec 4, 2025
jt2594838
pushed a commit
that referenced
this pull request
Dec 4, 2025
…ansferServiceClient (#16856) (#16857) * Pipe: Ignore logging when `returnSelf` is called in the event of an exception in `AsyncClient`. * Fix: Prevent duplicate error logging in AsyncPipeDataTransferServiceClient - Change printLogWhenEncounterException from final to mutable field - Set printLogWhenEncounterException to false in onError() to avoid repeated error logs - This prevents flooding logs when client encounters errors * update
JackieTien97
pushed a commit
that referenced
this pull request
Dec 8, 2025
…Client (#16856) * Fix: Prevent duplicate error logging in AsyncPipeDataTransferServiceClient - Change printLogWhenEncounterException from final to mutable field - Set printLogWhenEncounterException to false in onError() to avoid repeated error logs - This prevents flooding logs when client encounters errors * update (cherry picked from commit f4d628a)
JackieTien97
pushed a commit
that referenced
this pull request
Dec 9, 2025
…Client (#16856) * Fix: Prevent duplicate error logging in AsyncPipeDataTransferServiceClient - Change printLogWhenEncounterException from final to mutable field - Set printLogWhenEncounterException to false in onError() to avoid repeated error logs - This prevents flooding logs when client encounters errors * update (cherry picked from commit f4d628a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title said
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR