perf: Optimize TypeManager allocation in StatementAnalyzer #16870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid frequent object creation Problem: - Every time a SQL statement is analyzed, a new StatementAnalyzer instance is created - Each StatementAnalyzer instance creates a new InternalTypeManager object - InternalTypeManager initialization involves creating a ConcurrentHashMap and populating it with 11 type mappings - This happens for EVERY query, causing unnecessary object allocation and GC pressure Analysis: - InternalTypeManager is thread-safe (uses ConcurrentHashMap) - After construction, the type mappings are immutable (read-only) - All StatementAnalyzer instances use the same type mappings - No instance-specific state in InternalTypeManager Solution: - Changed 'private final TypeManager typeManager' to 'private final static TypeManager TYPE_MANAGER' - This ensures only ONE InternalTypeManager instance is created for the entire application - All StatementAnalyzer instances now share the same TYPE_MANAGER instance Performance Impact: - Reduces object allocation for every SQL query - Decreases GC pressure, especially under high query load - Saves memory by eliminating duplicate type mapping storage - No functional changes or thread-safety concerns
每次执行SQL查询时都会创建新的StatementAnalyzer实例，导致频繁创建InternalTypeManager对象。 InternalTypeManager是线程安全且不可变的，可以安全地作为静态变量共享。 优化: - 将typeManager从实例变量改为静态变量TYPE_MANAGER - 避免每次查询都创建新的InternalTypeManager实例 - 减少对象分配和GC压力 性能影响: - 减少内存分配 - 降低高并发查询场景下的GC压力 - 无功能变更，线程安全
jt2594838
approved these changes
Dec 5, 2025
JackieTien97
approved these changes
Dec 5, 2025
JackieTien97
pushed a commit
that referenced
this pull request
Dec 8, 2025
(cherry picked from commit 1b2b32b)
JackieTien97
pushed a commit
that referenced
this pull request
Dec 9, 2025
(cherry picked from commit 1b2b32b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The initialization cost of the TypeManager in StatementAnalyzer is too high. The TypeManager can be placed in the Coordinator to reduce unnecessary object creation.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR