From 116deaa2168b638d9f16f578961a8907d02633ac Mon Sep 17 00:00:00 2001 From: MarcosZyk <1534661820@qq.com> Date: Fri, 28 Apr 2023 10:22:46 +0800 Subject: [PATCH 1/2] fix if-else --- .../confignode/manager/ClusterSchemaManager.java | 13 ++++++++----- .../metadata/template/ClusterTemplateManager.java | 2 +- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/confignode/src/main/java/org/apache/iotdb/confignode/manager/ClusterSchemaManager.java b/confignode/src/main/java/org/apache/iotdb/confignode/manager/ClusterSchemaManager.java index 7f21222f623ae..1c1921f41d6ae 100644 --- a/confignode/src/main/java/org/apache/iotdb/confignode/manager/ClusterSchemaManager.java +++ b/confignode/src/main/java/org/apache/iotdb/confignode/manager/ClusterSchemaManager.java @@ -741,11 +741,14 @@ public synchronized TSStatus extendSchemaTemplate(TemplateExtendInfo templateExt } } - Template template = - clusterSchemaInfo - .getTemplate(new GetSchemaTemplatePlan(templateExtendInfo.getTemplateName())) - .getTemplateList() - .get(0); + TemplateInfoResp resp = + clusterSchemaInfo.getTemplate( + new GetSchemaTemplatePlan(templateExtendInfo.getTemplateName())); + if (resp.getStatus().getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()) { + return resp.getStatus(); + } + + Template template = resp.getTemplateList().get(0); boolean needExtend = false; for (String measurement : templateExtendInfo.getMeasurements()) { if (!template.hasSchema(measurement)) { diff --git a/server/src/main/java/org/apache/iotdb/db/metadata/template/ClusterTemplateManager.java b/server/src/main/java/org/apache/iotdb/db/metadata/template/ClusterTemplateManager.java index bfbb1644ca752..3869684833a47 100644 --- a/server/src/main/java/org/apache/iotdb/db/metadata/template/ClusterTemplateManager.java +++ b/server/src/main/java/org/apache/iotdb/db/metadata/template/ClusterTemplateManager.java @@ -196,7 +196,7 @@ public Template getTemplate(String name) { throw new RuntimeException( new IoTDBException(resp.status.getMessage(), resp.status.getCode())); } - } catch (Exception e) { + } catch (ClientManagerException | TException e) { throw new RuntimeException( new IoTDBException( "get template info error.", TSStatusCode.UNDEFINED_TEMPLATE.getStatusCode())); From 981da9bfeb74ae2ab5a8808a3da585fce0f6198f Mon Sep 17 00:00:00 2001 From: MarcosZyk <1534661820@qq.com> Date: Fri, 28 Apr 2023 10:30:54 +0800 Subject: [PATCH 2/2] fix error msg --- .../iotdb/db/metadata/template/ClusterTemplateManager.java | 5 ++--- .../apache/iotdb/db/metadata/template/ITemplateManager.java | 3 ++- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/src/main/java/org/apache/iotdb/db/metadata/template/ClusterTemplateManager.java b/server/src/main/java/org/apache/iotdb/db/metadata/template/ClusterTemplateManager.java index 3869684833a47..94898c97abdfb 100644 --- a/server/src/main/java/org/apache/iotdb/db/metadata/template/ClusterTemplateManager.java +++ b/server/src/main/java/org/apache/iotdb/db/metadata/template/ClusterTemplateManager.java @@ -183,7 +183,7 @@ public List