OAK-9712 - Add support for Azure SAS URIs in oak-run #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelmini
reviewed
Mar 4, 2022
| @@ -69,7 +82,7 @@ | |||
|
|
|||
| protected abstract SegmentNodeStorePersistence getDestPersistence() throws Exception; | |||
|
|
|||
| protected abstract String getSrcPathOrUri(); | |||
| protected abstract String getSrcPathOrUri() throws URISyntaxException, InvalidKeyException, StorageException, Exception; | |||
There was a problem hiding this comment.
I suggest to remove all these exceptions here and and modify getAzurePersistencePathOrUriSas()to catch all exceptions and rethrow a RuntimeException.
jelmini
approved these changes
Mar 4, 2022
smiroslav
approved these changes
Mar 4, 2022
|
@smiroslav @jelmini I see that this PR has been merged; there is still an unaddressed issue in the corresponding ticket however. Please look for an email in the oak-dev list on this topic. Thanks! |
|
In addition, the build for this PR had many failing modules because a license header was missing. See subsequent report OAK-9718. This PR was definitively not in a state to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.