diff --git a/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/MessageIdMapperTest.java b/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/MessageIdMapperTest.java index bbac7ad69e3..e9089e7bba8 100644 --- a/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/MessageIdMapperTest.java +++ b/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/MessageIdMapperTest.java @@ -31,7 +31,6 @@ import javax.mail.util.SharedByteArrayInputStream; import org.apache.james.mailbox.FlagsBuilder; -import org.apache.james.mailbox.MessageManager; import org.apache.james.mailbox.MessageManager.FlagsUpdateMode; import org.apache.james.mailbox.exception.MailboxException; import org.apache.james.mailbox.exception.MailboxNotFoundException; diff --git a/server/container/guice/cassandra-guice/src/main/java/org/apache/james/modules/mailbox/ElasticSearchMailboxModule.java b/server/container/guice/cassandra-guice/src/main/java/org/apache/james/modules/mailbox/ElasticSearchMailboxModule.java index d1b124bbef7..e4a101100bb 100644 --- a/server/container/guice/cassandra-guice/src/main/java/org/apache/james/modules/mailbox/ElasticSearchMailboxModule.java +++ b/server/container/guice/cassandra-guice/src/main/java/org/apache/james/modules/mailbox/ElasticSearchMailboxModule.java @@ -32,7 +32,6 @@ import org.apache.james.backends.es.IndexName; import org.apache.james.backends.es.NodeMappingFactory; import org.apache.james.backends.es.TypeName; -import org.apache.james.filesystem.api.FileSystem; import org.apache.james.mailbox.elasticsearch.IndexAttachments; import org.apache.james.mailbox.elasticsearch.MailboxElasticsearchConstants; import org.apache.james.mailbox.elasticsearch.MailboxMappingFactory; @@ -41,8 +40,8 @@ import org.apache.james.mailbox.store.search.ListeningMessageSearchIndex; import org.apache.james.mailbox.store.search.MessageSearchIndex; import org.apache.james.mailbox.tika.extractor.TikaTextExtractor; -import org.apache.james.utils.RetryExecutorUtil; import org.apache.james.utils.PropertiesProvider; +import org.apache.james.utils.RetryExecutorUtil; import org.elasticsearch.client.Client; import org.elasticsearch.client.transport.NoNodeAvailableException; import org.slf4j.Logger; diff --git a/server/container/guice/cassandra-guice/src/test/java/org/apache/james/DockerElasticSearchRule.java b/server/container/guice/cassandra-guice/src/test/java/org/apache/james/DockerElasticSearchRule.java index 3dd19c263e2..3598b4fd92c 100644 --- a/server/container/guice/cassandra-guice/src/test/java/org/apache/james/DockerElasticSearchRule.java +++ b/server/container/guice/cassandra-guice/src/test/java/org/apache/james/DockerElasticSearchRule.java @@ -19,9 +19,9 @@ package org.apache.james; -import com.google.inject.Module; +import java.util.Arrays; + import org.apache.commons.configuration.PropertiesConfiguration; -import org.apache.james.modules.mailbox.CassandraSessionConfiguration; import org.apache.james.modules.mailbox.ElasticSearchConfiguration; import org.apache.james.util.streams.SwarmGenericContainer; import org.junit.runner.Description; @@ -29,7 +29,7 @@ import org.testcontainers.shaded.com.github.dockerjava.api.model.ExposedPort; import org.testcontainers.shaded.com.github.dockerjava.api.model.Ports.Binding; -import java.util.Arrays; +import com.google.inject.Module; public class DockerElasticSearchRule implements GuiceModuleTestRule { diff --git a/server/container/guice/cassandra-guice/src/test/java/org/apache/james/JamesServerWithRetryConnectionTest.java b/server/container/guice/cassandra-guice/src/test/java/org/apache/james/JamesServerWithRetryConnectionTest.java index 018bda1da1a..ce18ad9a223 100644 --- a/server/container/guice/cassandra-guice/src/test/java/org/apache/james/JamesServerWithRetryConnectionTest.java +++ b/server/container/guice/cassandra-guice/src/test/java/org/apache/james/JamesServerWithRetryConnectionTest.java @@ -19,13 +19,7 @@ package org.apache.james; -import org.apache.james.util.streams.SwarmGenericContainer; -import org.junit.After; -import org.junit.Before; -import org.junit.Rule; -import org.junit.Test; -import org.testcontainers.DockerClientFactory; -import org.testcontainers.shaded.com.google.common.base.Throwables; +import static org.assertj.core.api.Assertions.assertThat; import java.io.IOException; import java.net.InetSocketAddress; @@ -36,16 +30,17 @@ import java.util.concurrent.Executors; import java.util.concurrent.TimeUnit; -import static org.assertj.core.api.Assertions.assertThat; +import org.apache.james.util.streams.SwarmGenericContainer; +import org.junit.After; +import org.junit.Before; +import org.junit.Rule; +import org.junit.Test; +import org.testcontainers.shaded.com.google.common.base.Throwables; public class JamesServerWithRetryConnectionTest { private static final int IMAP_PORT = 1143; private static final long WAITING_TIME = TimeUnit.MILLISECONDS.convert(10, TimeUnit.SECONDS); - private static String getDockerHostIp() { - return DockerClientFactory.instance().dockerHostIpAddress(); - } - private final DockerCassandraRule dockerCassandraRule = new DockerCassandraRule(); private final DockerElasticSearchRule dockerElasticSearchRule = new DockerElasticSearchRule(); diff --git a/server/container/guice/guice-common/src/main/java/org/apache/james/utils/RetryExecutorUtil.java b/server/container/guice/guice-common/src/main/java/org/apache/james/utils/RetryExecutorUtil.java index 32b807e4357..8737ffec13f 100644 --- a/server/container/guice/guice-common/src/main/java/org/apache/james/utils/RetryExecutorUtil.java +++ b/server/container/guice/guice-common/src/main/java/org/apache/james/utils/RetryExecutorUtil.java @@ -26,7 +26,7 @@ public class RetryExecutorUtil { public static final int INITIAL_DELAY_MILLIS = 500; public static final int MULTIPLIER = 2; - public static AsyncRetryExecutor retryOnExceptions(AsyncRetryExecutor executor, int maxRetries, int minDelay, Class... clazz) { + public static AsyncRetryExecutor retryOnExceptions(AsyncRetryExecutor executor, int maxRetries, int minDelay, Class clazz) { return executor .retryOn(clazz) .withExponentialBackoff(INITIAL_DELAY_MILLIS, MULTIPLIER) diff --git a/server/container/guice/guice-common/src/test/java/org/apache/james/utils/FileConfigurationProviderTest.java b/server/container/guice/guice-common/src/test/java/org/apache/james/utils/FileConfigurationProviderTest.java index 04562f24f85..6318fc74498 100644 --- a/server/container/guice/guice-common/src/test/java/org/apache/james/utils/FileConfigurationProviderTest.java +++ b/server/container/guice/guice-common/src/test/java/org/apache/james/utils/FileConfigurationProviderTest.java @@ -21,7 +21,6 @@ import static org.assertj.core.api.Assertions.assertThat; -import org.apache.commons.configuration.ConfigurationException; import org.apache.commons.configuration.HierarchicalConfiguration; import org.apache.james.core.JamesServerResourceLoader; import org.apache.james.core.filesystem.FileSystemImpl; diff --git a/server/container/guice/guice-common/src/test/java/org/apache/james/utils/RetryExecutorUtilTest.java b/server/container/guice/guice-common/src/test/java/org/apache/james/utils/RetryExecutorUtilTest.java index 32477abc749..a9354f4e423 100644 --- a/server/container/guice/guice-common/src/test/java/org/apache/james/utils/RetryExecutorUtilTest.java +++ b/server/container/guice/guice-common/src/test/java/org/apache/james/utils/RetryExecutorUtilTest.java @@ -19,22 +19,23 @@ package org.apache.james.utils; -import com.nurkiewicz.asyncretry.AsyncRetryExecutor; -import com.nurkiewicz.asyncretry.RetryExecutor; -import org.junit.After; -import org.junit.Before; -import org.junit.Test; -import org.mockito.Mock; -import org.mockito.MockitoAnnotations; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; +import static org.mockito.BDDMockito.given; import java.util.concurrent.CompletableFuture; import java.util.concurrent.ExecutionException; import java.util.concurrent.Executors; import java.util.concurrent.ScheduledExecutorService; -import static org.assertj.core.api.Assertions.assertThat; -import static org.assertj.core.api.Assertions.assertThatThrownBy; -import static org.mockito.BDDMockito.given; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.mockito.Mock; +import org.mockito.MockitoAnnotations; + +import com.nurkiewicz.asyncretry.AsyncRetryExecutor; +import com.nurkiewicz.asyncretry.RetryExecutor; public class RetryExecutorUtilTest { private static final int MAX_RETRIES = 3; @@ -57,6 +58,7 @@ public void tearDown() throws Exception { } @Test + @SuppressWarnings("unchecked") public void retryOnExceptionsAndExecuteShouldRethrowWhenScheduledServiceAlwaysThrowException() throws Exception { given(serviceMock.faultyService()) .willThrow(IllegalArgumentException.class) @@ -72,6 +74,7 @@ public void retryOnExceptionsAndExecuteShouldRethrowWhenScheduledServiceAlwaysTh } @Test + @SuppressWarnings("unchecked") public void retryOnExceptionsAndExecuteShouldRetryWhenMatchExceptionAndSuccess() throws Exception { given(serviceMock.faultyService()) .willThrow(IllegalArgumentException.class) @@ -84,6 +87,7 @@ public void retryOnExceptionsAndExecuteShouldRetryWhenMatchExceptionAndSuccess() } @Test + @SuppressWarnings("unchecked") public void retryOnExceptionsAndExecuteShouldNotRetryWhenDoesNotMatchException() throws Exception { given(serviceMock.faultyService()) .willThrow(IllegalStateException.class) @@ -97,6 +101,7 @@ public void retryOnExceptionsAndExecuteShouldNotRetryWhenDoesNotMatchException() } @Test + @SuppressWarnings("unchecked") public void retryOnExceptionsAndExecuteShouldRetryWithMaxTimesAndReturnValue() throws Exception { given(serviceMock.faultyService()) .willThrow(IllegalStateException.class, IllegalStateException.class, IllegalStateException.class) @@ -110,6 +115,7 @@ public void retryOnExceptionsAndExecuteShouldRetryWithMaxTimesAndReturnValue() t } @Test + @SuppressWarnings("unchecked") public void retryOnExceptionsAndExecuteShouldFailIfFailMoreThanMaxRetry() throws Exception { given(serviceMock.faultyService()). willThrow(IllegalStateException.class, IllegalStateException.class, IllegalStateException.class, IllegalStateException.class). diff --git a/server/container/guice/jmx/src/main/java/org/apache/james/modules/server/JMXServer.java b/server/container/guice/jmx/src/main/java/org/apache/james/modules/server/JMXServer.java index 8be9f76307f..49b0893d2e9 100644 --- a/server/container/guice/jmx/src/main/java/org/apache/james/modules/server/JMXServer.java +++ b/server/container/guice/jmx/src/main/java/org/apache/james/modules/server/JMXServer.java @@ -37,7 +37,6 @@ import org.apache.commons.configuration.ConfigurationException; import org.apache.commons.configuration.PropertiesConfiguration; -import org.apache.james.filesystem.api.FileSystem; import org.apache.james.util.RestrictingRMISocketFactory; import org.apache.james.utils.PropertiesProvider; import org.slf4j.Logger; diff --git a/server/container/guice/protocols/jmap/src/main/java/org/apache/james/jmap/JMAPModule.java b/server/container/guice/protocols/jmap/src/main/java/org/apache/james/jmap/JMAPModule.java index 73ef2f596d0..a43b0d694b0 100644 --- a/server/container/guice/protocols/jmap/src/main/java/org/apache/james/jmap/JMAPModule.java +++ b/server/container/guice/protocols/jmap/src/main/java/org/apache/james/jmap/JMAPModule.java @@ -25,7 +25,6 @@ import java.util.Optional; import org.apache.commons.configuration.ConfigurationException; -import org.apache.commons.configuration.DefaultConfigurationBuilder; import org.apache.commons.configuration.PropertiesConfiguration; import org.apache.commons.io.FileUtils; import org.apache.james.filesystem.api.FileSystem;