Skip to content

Use RFC6570 Level 1 URI Template for JMAP downloadUrl#257

Closed
antonok-edm wants to merge 1 commit into
apache:masterfrom
antonok-edm:jmap-downloadurl-rfc6570
Closed

Use RFC6570 Level 1 URI Template for JMAP downloadUrl#257
antonok-edm wants to merge 1 commit into
apache:masterfrom
antonok-edm:jmap-downloadurl-rfc6570

Conversation

@antonok-edm

Copy link
Copy Markdown
Contributor

Section 2 of RFC8620 describes the downloadUrl property of the JMAP Session resource as follows:

downloadUrl: String The URL endpoint to use when downloading files, in URI Template (level 1) format RFC6570. The URL MUST contain variables called accountId, blobId, type, and name. The use of these variables is described in Section 6.2. Due to potential encoding issues with slashes in content types, it is RECOMMENDED to put the type variable in the query section of the URL.

I've updated the downloadUrl property to be returned in the correct Level 1 URI Template format by surrounding each expression with curly braces rather than the previous leading-$ format.

@chibenwa chibenwa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ;-)

@chibenwa

Copy link
Copy Markdown
Contributor

linagora@9e873a8 do add accountId parameter for upload URL too.

@Arsnael Arsnael left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @antonok-edm :)

@antonok-edm

Copy link
Copy Markdown
Contributor Author

Closing - looks like this has been merged now.

@chibenwa

Copy link
Copy Markdown
Contributor

Yes you are right!

Much sorry for not telling it here...

Apologies.

Benoit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants