Skip to content
Permalink
Browse files
Avoid injecting on final fields
This can cause thread visibility issues.  Found via error-prone.
  • Loading branch information
gaul committed Aug 29, 2017
1 parent 3815282 commit 20854e736eb071f1801c323deec3458c157c0f5d
Showing 2 changed files with 2 additions and 2 deletions.
@@ -71,7 +71,7 @@ public class GlacierBlobStore extends BaseBlobStore {

@Inject(optional = true)
@Named("jclouds.glacier.inventory.update.time")
private final long inventoryUpdateTime = DEFAULT_INVENTORY_UPDATE_TIME;
private long inventoryUpdateTime = DEFAULT_INVENTORY_UPDATE_TIME;

private final GlacierClient sync;
private final Provider<MultipartUploadStrategy> multipartUploadStrategy;
@@ -40,7 +40,7 @@ public class BaseSlicingStrategy implements SlicingStrategy {

@Inject(optional = true)
@Named("jclouds.mpu.part.ratio")
private final double ratio = DEFAULT_RATIO;
private double ratio = DEFAULT_RATIO;

private final PayloadSlicer slicer;
private Payload payload;

0 comments on commit 20854e7

Please sign in to comment.