Skip to content
Permalink
Browse files
Make errorProne happy and remove unused parameter from newly introduc…
…ed private method
  • Loading branch information
FSchumacher committed Mar 5, 2022
1 parent 2416a64 commit 47f16d06fa4531bfdb92ce41073c0bbff83aa0ea
Showing 1 changed file with 8 additions and 6 deletions.
@@ -130,15 +130,16 @@ protected RegexpHTMLParser() {
* {@inheritDoc}
*/
@Override
public Iterator<URL> getEmbeddedResourceURLs(String userAgent, byte[] html, URL baseUrl, URLCollection urls, String encoding) throws HTMLParseException {
public Iterator<URL> getEmbeddedResourceURLs(String userAgent, byte[] html, URL baseUrl,
URLCollection urls, String encoding) throws HTMLParseException {
if (useJavaRegex) {
return getEmbeddedResourceURLsWithJavaRegex(userAgent,html, baseUrl, urls, encoding);
return getEmbeddedResourceURLsWithJavaRegex(html, baseUrl, urls, encoding);
}
return getEmbeddedResourceURLsWithOroRegex(userAgent,html, baseUrl, urls, encoding);
return getEmbeddedResourceURLsWithOroRegex(html, baseUrl, urls, encoding);
}

private Iterator<URL> getEmbeddedResourceURLsWithJavaRegex(String userAgent, byte[] html, URL baseUrl,
URLCollection urls, String encoding) throws HTMLParseException {
private Iterator<URL> getEmbeddedResourceURLsWithJavaRegex(byte[] html, URL baseUrl, URLCollection urls,
String encoding) throws HTMLParseException {
try {

// TODO: find a way to avoid the cost of creating a String here --
@@ -188,7 +189,8 @@ private Iterator<URL> getEmbeddedResourceURLsWithJavaRegex(String userAgent, byt
}
}

private Iterator<URL> getEmbeddedResourceURLsWithOroRegex(String userAgent, byte[] html, URL baseUrl, URLCollection urls, String encoding) throws HTMLParseException {
private Iterator<URL> getEmbeddedResourceURLsWithOroRegex(byte[] html, URL baseUrl, URLCollection urls,
String encoding) throws HTMLParseException {
Pattern pattern= null;
Perl5Matcher matcher = null;
try {

0 comments on commit 47f16d0

Please sign in to comment.