Skip to content
Permalink
Browse files
Revert Bugfix 65885 (#709)
* Revert Bugfix 65885

* Update changes

* Fix style violation
  • Loading branch information
pmouawad committed May 9, 2022
1 parent 4f05afc commit a997ed23ce0f9625f92f98314b22d09a6ac96dd6
Showing 3 changed files with 2 additions and 5 deletions.
@@ -97,7 +97,8 @@ static String getErrorKey(Sample sample) {
"/" + escapeJson(responseMessage) : "");

if (MetricUtils.isSuccessCode(responseCode) ||
StringUtils.isNotBlank(sample.getFailureMessage())) {
(StringUtils.isEmpty(responseCode) &&
StringUtils.isNotBlank(sample.getFailureMessage()))) {
key = MetricUtils.ASSERTION_FAILED;
if (ASSERTION_RESULTS_FAILURE_MESSAGE) {
String msg = sample.getFailureMessage();
@@ -57,9 +57,6 @@ public void testGetErrorKey() {
sample = new Sample(0, metadata, new String[] { "false", "403", "", "" });
assertEquals("403", ErrorsSummaryConsumer.getErrorKey(sample));

sample = new Sample(0, metadata, new String[] { "false", "403", "", "FailureMessage" });
assertEquals("FailureMessage", ErrorsSummaryConsumer.getErrorKey(sample));

sample = new Sample(0, metadata, new String[] { "false", "500", "Server Error", "" });
assertEquals("500/Server Error", ErrorsSummaryConsumer.getErrorKey(sample));
}
@@ -147,7 +147,6 @@ however, the profile can't be updated while the test is running.
<h3>Report / Dashboard</h3>
<ul>
<li><bug>65353</bug>Make the estimator used for calculating percentiles on the dashboard configurable</li>
<li><bug>65885</bug>HTML Report: Error report displays wrong failure message when Response Assertion checks Ignore Status and response code is not 200</li>
</ul>

<h3>General</h3>

0 comments on commit a997ed2

Please sign in to comment.