Permalink
Browse files

Initial stab at checkstyle target

git-svn-id: https://svn.apache.org/repos/asf/jakarta/jmeter/trunk@1056399 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information...
1 parent d2e29f7 commit d62816669e6dde158ebaa8b28cbd649b6b3c826d @sebbASF sebbASF committed Jan 7, 2011
Showing with 116 additions and 0 deletions.
  1. +11 −0 build.xml
  2. +105 −0 checkstyle.xml
View
@@ -2113,4 +2113,15 @@ run JMeter unless all the JMeter jars are added.
<param name="_check_exists" value="true"/>
</antcall>
</target>
+
+ <target name="checkstyle">
+ <taskdef resource="checkstyletask.properties"
+ classpath="${lib.opt}/checkstyle-5.3-all.jar"/>
+ <checkstyle config="checkstyle.xml">
+ <fileset dir="src" includes="**/*.java"/>
+ <formatter type="plain"/>
+ <formatter type="xml" toFile="build/checkstyle_errors.xml"/>
+ </checkstyle>
+
+ </target>
</project>
View
@@ -0,0 +1,105 @@
+<?xml version="1.0"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<!DOCTYPE module PUBLIC
+ "-//Puppy Crawl//DTD Check Configuration 1.1//EN"
+ "http://www.puppycrawl.com/dtds/configuration_1_1.dtd">
+
+<!--
+ Checkstyle checks configured for Maven.
+-->
+
+<module name="Checker">
+
+ <property name="localeLanguage" value="en"/>
+
+ <!-- Verify that EVERY source file has the appropriate license -->
+<!--
+ <module name="Header">
+ <property name="headerFile" value="${checkstyle.header.file}"/>
+ </module>
+-->
+
+ <!-- No tabs allowed! -->
+ <module name="FileTabCharacter"/>
+
+ <module name="TreeWalker">
+
+ <!-- Operator must be at end of wrapped line -->
+<!--
+ <module name="OperatorWrap">
+ <property name="option" value="eol"/>
+ </module>
+-->
+
+ <!-- Interfaces must be types (not just constants) -->
+ <module name="InterfaceIsType"/>
+
+ <!-- Must have class / interface header comments -->
+<!--
+ <module name="JavadocType"/>
+-->
+ <!-- Require method javadocs, allow undeclared RTE -->
+<!--
+ <module name="JavadocMethod">
+ <property name="allowUndeclaredRTE" value="true"/>
+ <property name="allowMissingThrowsTags" value="true"/>
+ </module>
+-->
+
+ <!-- Require field javadoc -->
+<!--
+ <module name="JavadocVariable"/>
+-->
+
+ <!-- No public fields -->
+<!--
+ <module name="VisibilityModifier">
+ <property name="protectedAllowed" value="true"/>
+ </module>
+-->
+
+ <!-- Require hash code override when equals is -->
+ <module name="EqualsHashCode"/>
+
+ <!-- Disallow unnecessary instantiation of Boolean, String -->
+ <module name="IllegalInstantiation">
+ <property name="classes" value="java.lang.Boolean, java.lang.String"/>
+ </module>
+
+ <!-- Required for SuppressionCommentFilter below -->
+ <module name="FileContentsHolder"/>
+
+ </module>
+
+ <!-- Require package javadoc -->
+<!--
+ <module name="JavadocPackage"/>
+-->
+
+ <!-- Setup special comments to suppress specific checks from source files -->
+ <module name="SuppressionCommentFilter">
+ <property name="offCommentFormat" value="CHECKSTYLE\: stop all checks"/>
+ <property name="onCommentFormat" value="CHECKSTYLE\: resume checking"/>
+ </module>
+ <module name="SuppressionCommentFilter">
+ <property name="offCommentFormat" value="CHECKSTYLE\: stop VisibilityModifier"/>
+ <property name="onCommentFormat" value="CHECKSTYLE\: resume VisibilityModifier"/>
+ <property name="checkFormat" value="VisibilityModifier"/>
+ </module>
+
+</module>

0 comments on commit d628166

Please sign in to comment.