New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small memory improvement : do dot convert all the url to check the prefix #228

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
4 participants
@benbenw

benbenw commented Sep 8, 2016

prefix

@benbenw benbenw changed the title from small memory improvement : do dot convert all the url to check the to small memory improvement : do dot convert all the url to check the prefix Sep 8, 2016

@vlsi

This comment has been minimized.

Show comment
Hide comment
@vlsi

vlsi Sep 8, 2016

Looks good. Just one question: HOW did you find that?

vlsi commented Sep 8, 2016

Looks good. Just one question: HOW did you find that?

@sebbASF

This comment has been minimized.

Show comment
Hide comment
@sebbASF

sebbASF Sep 8, 2016

Contributor

It may be slightly more efficient to use regionMatches, but it's not nearly so obvious what the code is doing.

However checking log.isDebugEnabled() first is an improvement.

Contributor

sebbASF commented Sep 8, 2016

It may be slightly more efficient to use regionMatches, but it's not nearly so obvious what the code is doing.

However checking log.isDebugEnabled() first is an improvement.

@FSchumacher

This comment has been minimized.

Show comment
Hide comment
@FSchumacher

FSchumacher Sep 8, 2016

Contributor

There is StringUtils#startsWithIgnoreCase, that does the same and is clearly named.

Contributor

FSchumacher commented Sep 8, 2016

There is StringUtils#startsWithIgnoreCase, that does the same and is clearly named.

asfgit pushed a commit that referenced this pull request Sep 8, 2016

@asfgit asfgit closed this in 5d1c388 Sep 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment