Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds a time boxed sampling for backend listeners #237
Conversation
milamberspace
and others
added some commits
Nov 16, 2016
FSchumacher
suggested changes
Dec 11, 2016
Thanks for the contribution.
Overall it looks good. Maybe you could also describe the use case for this feature compared to the fixed-size one.
| /** | ||
| * Metrics are sent into boxes which can be {@link #FIXED a fixed-size sliding window} or {@link #TIMED time boxed}. | ||
| * @author Logan Mzz |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
| stat.clear(); | ||
| } | ||
| break; | ||
| default: throw new UnsupportedOperationException(windowMode.name()); |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
| // http://commons.apache.org/proper/commons-math/userguide/stat.html | ||
| break; | ||
| case TIMED: | ||
| for (DescriptiveStatistics stat : windowedStats) { |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
| int slidingWindowSize = JMeterUtils.getPropDefault("backend_metrics_window", 100); | ||
| // Limit to sliding window of SLIDING_WINDOW_SIZE values | ||
| for (DescriptiveStatistics stat : stats) { |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
| @@ -917,6 +917,8 @@ summariser.name=summary | ||
| # BackendListener - configuration | ||
| #--------------------------------------------------------------------------- | ||
| # | ||
| # Backend metrics window mode (fixed=fixed-size window, timed=time boxed) | ||
| #backend_metrics_window_mode=fixed |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
FSchumacher
Dec 11, 2016
Contributor
Documentation is missing for this new feature. It should be mentioned in the properties section and the users manual.
FSchumacher
Dec 11, 2016
Contributor
Documentation is missing for this new feature. It should be mentioned in the properties section and the users manual.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pmouawad
Dec 14, 2016
Contributor
Hello @max3163,
Thank you for your contribution.
Could you (as requested by Felix) give more details on the use case for this PR ?
Thank you
Regards
|
Hello @max3163, |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
max3163
Dec 14, 2016
Contributor
When you use the fixed metric window mode, all samples metrics are saved in a sliding array with a fix size, you send each second to your backend a trend of this values
When you use the time boxed mode, all samples metrics are reset in order to send actual values for the last elapse time.
I you use it with a Influxdb backend (I'm thinking to send a PR to share it too) with a pooling of 5 seconds.
|
When you use the fixed metric window mode, all samples metrics are saved in a sliding array with a fix size, you send each second to your backend a trend of this values |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pmouawad
Dec 28, 2016
Contributor
Hello Team,
PR looks fine to me.
Do you agree with enhancement ?
Thank you
|
Hello Team, |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Wyatts
Dec 28, 2016
This sounds good if it's what I think it is. Definitely would appreciate a clear description of what it precisely does, though.
Wyatts
commented
Dec 28, 2016
|
This sounds good if it's what I think it is. Definitely would appreciate a clear description of what it precisely does, though. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pmouawad
Dec 30, 2016
Contributor
@max3163 , are you using GraphiteBackendListener or something else (I don't fully understand your comment on "I'm thinking to send a PR to share it too".
If not, why aren't you using it ?
Thanks
|
@max3163 , are you using GraphiteBackendListener or something else (I don't fully understand your comment on "I'm thinking to send a PR to share it too". |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
max3163
Dec 31, 2016
Contributor
@pmouawad
We use ur own BackendListener to send metric on InfluxDB with his HTTP API and follow his own shema design ( see : Influxdb data design ) which is more better than use the Graphite plugin.
If you want, we can share this BackendListener.
|
@pmouawad |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pmouawad
Jan 2, 2017
Contributor
Hello,
Thanks for proposal.
What is the quantity of code ? Does it have any dependency on Influx library or it is standalone using socket ?
Thank you
|
Hello, Thank you |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
max3163
Jan 4, 2017
Contributor
Hi,
I just sent you a new PR ( #246 ) for the Influxdb backend.
It's about 650 lines of code ( test class included ) and with no dependency on Influxdb library.
max3163
commented
Jan 4, 2017
•
edited
Edited 1 time
-
max3163
edited Jan 4, 2017 (most recent)
edited
-
Jan 4, 2017 (most recent)
|
Hi, I just sent you a new PR ( #246 ) for the Influxdb backend. |
added a commit
to max3163/jmeter
that referenced
this pull request
Jan 4, 2017
max3163 commentedDec 9, 2016
No description provided.