New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilised Java 8 (and 7) features to tidy up code #255

Closed
wants to merge 8 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@ham1

ham1 commented Jan 21, 2017

Used lambdas, method references, multi-catch blocks and ThreadLocal.withInitial to improve code readability.
Also removed unnecessary types.

@FSchumacher

This comment has been minimized.

Show comment
Hide comment
@FSchumacher

FSchumacher Jan 22, 2017

Contributor

Thanks for your contribution.

Looks good, but as usual, I would have liked to see the different cleanups in different commits.

Contributor

FSchumacher commented Jan 22, 2017

Thanks for your contribution.

Looks good, but as usual, I would have liked to see the different cleanups in different commits.

@ham1

This comment has been minimized.

Show comment
Hide comment
@ham1

ham1 Jan 22, 2017

Sorry, updated now.

ham1 commented Jan 22, 2017

Sorry, updated now.

asfgit pushed a commit that referenced this pull request Jan 22, 2017

Utilised Java 8 (and 7) features to tidy up code. Contributed by Grah…
…am Russell (graham at ham1.co.uk). Part 1/8 of github pr #255

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1779801 13f79535-47bb-0310-9956-ffa450edef68

asfgit pushed a commit that referenced this pull request Jan 22, 2017

Utilised Java 8 (and 7) features to tidy up code. Removed unnecessary…
… types. Contributed by Graham Russell (graham at ham1.co.uk). Part 2/8 of github pr #255

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1779802 13f79535-47bb-0310-9956-ffa450edef68

asfgit pushed a commit that referenced this pull request Jan 22, 2017

Utilised Java 8 (and 7) features to tidy up code. Used ThreadLocal.wi…
…thInital. Contributed by Graham Russell (graham at ham1.co.uk). Part 3/8 of github pr #255

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1779803 13f79535-47bb-0310-9956-ffa450edef68

asfgit pushed a commit that referenced this pull request Jan 22, 2017

Utilised Java 8 (and 7) features to tidy up code. Used multi-catch. C…
…ontributed by Graham Russell (graham at ham1.co.uk). Part 4/8 of github pr #255

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1779804 13f79535-47bb-0310-9956-ffa450edef68

asfgit pushed a commit that referenced this pull request Jan 22, 2017

Utilised Java 8 (and 7) features to tidy up code. Used removeIf. Cont…
…ributed by Graham Russell (graham at ham1.co.uk). Part 5/8 of github pr #255

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1779805 13f79535-47bb-0310-9956-ffa450edef68

asfgit pushed a commit that referenced this pull request Jan 22, 2017

Utilised Java 8 (and 7) features to tidy up code. Used .sort. Contrib…
…uted by Graham Russell (graham at ham1.co.uk). Part 6/8 of github pr #255

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1779809 13f79535-47bb-0310-9956-ffa450edef68

asfgit pushed a commit that referenced this pull request Jan 22, 2017

Utilised Java 8 (and 7) features to tidy up code. Formatting and mino…
…r tweaks. Contributed by Graham Russell (graham at ham1.co.uk). Part 7/8 of github pr #255

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1779811 13f79535-47bb-0310-9956-ffa450edef68

asfgit pushed a commit that referenced this pull request Jan 22, 2017

Utilised Java 8 (and 7) features to tidy up code. Formatting and mino…
…r tweaks. Contributed by Graham Russell (graham at ham1.co.uk). Part 8/8 of github pr #255. This closes #225.

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1779812 13f79535-47bb-0310-9956-ffa450edef68
@ham1

This comment has been minimized.

Show comment
Hide comment
@ham1

ham1 Jan 22, 2017

Thanks.

ham1 commented Jan 22, 2017

Thanks.

@ham1 ham1 closed this Jan 22, 2017

@ham1 ham1 deleted the ham1:java8 branch Jan 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment