Refactored and reformatted SmtpSampler#259
Closed
ham1 wants to merge 1 commit into
Closed
Conversation
…ier to read. Minor changes to SendMailCommand
asfgit
pushed a commit
that referenced
this pull request
Jan 30, 2017
Part 1/2 of PR contributed by Graham Russell comment #259 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1780960 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I understand this is a fairly big change with no tests but I thought I'd submit anyway in the hope that someone had some good SMTP tests or someone was willing to review or even just apply a subset of the changes.