Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Save backup refactor #324
Further refactoring for readability to
Motivation and Context
The aim is to improve readability and thus make fixing, testing and improving easier.
How Has This Been Tested?
Manually with both backup settings set. Unit testing is still not very easy.
Screenshots (if appropriate):
Types of changes
@@ Coverage Diff @@ ## trunk #324 +/- ## ============================================ + Coverage 57.75% 57.75% +<.01% - Complexity 9913 9915 +2 ============================================ Files 1139 1139 Lines 73051 73050 -1 Branches 7303 7300 -3 ============================================ + Hits 42187 42188 +1 + Misses 28392 28390 -2 Partials 2472 2472
@pmouawad Thank you for committing my changes - in future I'm happy to rebase and fix merge issues so you don't have to :) (just let me know via comment or email)
There were only a few minor things:
What's the best way for me to provide these changes? Force push to this PR, new PR, email patch file?