New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilising more modern Java, simplifying code and formatting code and comments #327

Closed
wants to merge 3 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@ham1

ham1 commented Nov 13, 2017

Description

Three commits covering three types of change:

  • Formatting and comment tidy up
  • Use modern Java, streams, computeIfAbsent etc.
  • Simplify code and reduce nesting

Feel free to take only some, I did this while trying to better understand the code.

Motivation and Context

Improve readability etc.

How Has This Been Tested?

Ant test, no functional changes.

Screenshots (if appropriate):

Types of changes

  • Code improvement

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
@codecov-io

This comment has been minimized.

codecov-io commented Nov 13, 2017

Codecov Report

Merging #327 into trunk will increase coverage by 0.03%.
The diff coverage is 20.32%.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk     #327      +/-   ##
============================================
+ Coverage     57.83%   57.87%   +0.03%     
+ Complexity     9937     9935       -2     
============================================
  Files          1141     1141              
  Lines         73217    73166      -51     
  Branches       7305     7277      -28     
============================================
- Hits          42346    42342       -4     
+ Misses        28405    28356      -49     
- Partials       2466     2468       +2
Impacted Files Coverage Δ Complexity Δ
...ore/org/apache/jmeter/gui/action/AboutCommand.java 0% <ø> (ø) 0 <0> (ø) ⬇️
src/core/org/apache/jmeter/gui/GUIFactory.java 0% <ø> (ø) 0 <0> (ø) ⬇️
src/core/org/apache/jmeter/gui/action/Move.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...core/org/apache/jmeter/gui/SimpleCompoundEdit.java 33.33% <ø> (ø) 1 <0> (ø) ⬇️
...core/org/apache/jmeter/gui/SavePropertyDialog.java 4% <ø> (ø) 1 <0> (ø) ⬇️
...core/org/apache/jmeter/gui/GlobalUndoableEdit.java 0% <ø> (ø) 0 <0> (ø) ⬇️
src/core/org/apache/jmeter/gui/CommentPanel.java 100% <ø> (ø) 5 <0> (ø) ⬇️
...rc/core/org/apache/jmeter/gui/UndoHistoryItem.java 57.14% <ø> (ø) 2 <0> (ø) ⬇️
...org/apache/jmeter/gui/action/SearchTreeDialog.java 1.86% <0%> (+0.02%) 1 <0> (ø) ⬇️
...e/org/apache/jmeter/gui/action/AbstractAction.java 21.27% <0%> (+0.86%) 2 <0> (ø) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358acbb...25e663c. Read the comment docs.

asfgit pushed a commit that referenced this pull request Nov 15, 2017

Utilising more modern Java, simplifying code and formatting code and …
…comments

This comment #327 (PART 1)

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1815391 13f79535-47bb-0310-9956-ffa450edef68

asfgit pushed a commit that referenced this pull request Nov 15, 2017

Utilising more modern Java, simplifying code and formatting code and …
…comments

This comment #327 (PART 2)

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1815392 13f79535-47bb-0310-9956-ffa450edef68

@asfgit asfgit closed this in 041659b Nov 15, 2017

@ham1 ham1 deleted the ham1:formatting_whitespace_etc branch Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment