Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test isIgnore after post processor and assertions #341

Closed
wants to merge 1 commit into from

Conversation

@max3163
Copy link
Contributor

commented Nov 24, 2017

Actually, the new setIgnore() method allow to not send the sampleResut to all listeners.
But you have to set the property in the sampler, you can't change it on a post-processor or in a assertion script.

This PR allow it

@pmouawad

This comment has been minimized.

Copy link
Contributor

commented Nov 24, 2017

Hi @max3163 ,
0/ In order to justify the user case, can you illustrate your use case ?
1/ I think we should add a log in debug level when we ignore a SampleResult
2/ Could you also add either a JUnit or an integration test (jmx test) that tests different cases:

  • ignore only in JSR223Sampler
  • ignore only in Assertion
  • ignore only in PostProcessor
    3/ Can you add a comment on the reason for the multiple test ? when reading the code, I forgot for few minutes the initial intent ,and it was not clear for me.
    Comment like:
    "setIgnore can be called in Assertion or PostProcessors so test again"

Thanks

@FSchumacher

This comment has been minimized.

Copy link
Contributor

commented Nov 25, 2017

I wonder, whether instead of or additionally to the new setIgnore method, we should add and expose a setMetadata(type, content) method.
I believe it would be useful for example to:

  • mark samples to be ignored by listeners and such
  • use the information later on to group by (a use case would be to group by some user given metadata in the view results tree)
@pmouawad

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2017

Hi @FSchumacher ,
Good idea.
Is this in relation with #313 ?
Thanks

@FSchumacher

This comment has been minimized.

Copy link
Contributor

commented Dec 2, 2017

Yes, but also to enable us to filter in view results tree on those meta information. It could be something like a comment, a thread name or anything else.

@asfgit asfgit closed this in 5cdf7ac Feb 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.