New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed about dialog position on first view #351

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@ham1

ham1 commented Dec 7, 2017

Description

When viewing "About JMeter" dialog it was positioned with the top corner in the middle rather than in the centre of the screen because the first time the dialog wasn't pack()'ed so didn't have any size.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
@codecov-io

This comment has been minimized.

codecov-io commented Dec 7, 2017

Codecov Report

Merging #351 into trunk will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk     #351      +/-   ##
============================================
+ Coverage     58.28%   58.29%   +<.01%     
- Complexity    10217    10219       +2     
============================================
  Files          1160     1160              
  Lines         74426    74427       +1     
  Branches       7343     7343              
============================================
+ Hits          43378    43384       +6     
+ Misses        28552    28549       -3     
+ Partials       2496     2494       -2
Impacted Files Coverage Δ Complexity Δ
...ore/org/apache/jmeter/gui/action/AboutCommand.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...apache/jmeter/extractor/TestBoundaryExtractor.java 97.88% <0%> (ø) 17% <0%> (ø) ⬇️
...mpler/hc/JMeterPoolingClientConnectionManager.java 30.95% <0%> (+3.17%) 11% <0%> (+1%) ⬆️
...s/org/apache/jmeter/timers/PoissonRandomTimer.java 78.37% <0%> (+5.4%) 10% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286a89e...f98175c. Read the comment docs.

@ham1

This comment has been minimized.

ham1 commented Dec 7, 2017

Can't see how this change caused a test failure...

@asfgit asfgit closed this in 916381d Dec 7, 2017

@ham1 ham1 deleted the ham1:about_position branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment