New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu bar - added mnemonics to more menu items #352

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@ham1

ham1 commented Dec 7, 2017

Description

  • added mnemonics to more menu items
  • general refactor/tidy of code

Motivation and Context

To make navigation easier, e.g. now to open most recent project, Alt+F, Alt+E, Enter.

How Has This Been Tested?

Manually on Linux Mint

Screenshots (if appropriate):

Types of changes

  • Dev improvement and
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
@codecov-io

This comment has been minimized.

codecov-io commented Dec 7, 2017

Codecov Report

Merging #352 into trunk will increase coverage by <.01%.
The diff coverage is 84.93%.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk     #352      +/-   ##
============================================
+ Coverage     58.28%   58.28%   +<.01%     
- Complexity    10217    10218       +1     
============================================
  Files          1160     1160              
  Lines         74426    74408      -18     
  Branches       7343     7337       -6     
============================================
- Hits          43378    43369       -9     
+ Misses        28552    28546       -6     
+ Partials       2496     2493       -3
Impacted Files Coverage Δ Complexity Δ
...c/core/org/apache/jmeter/gui/util/MenuFactory.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...core/org/apache/jmeter/gui/util/JMeterMenuBar.java 76.21% <87.32%> (+0.56%) 49 <7> (+1) ⬆️
...apache/jmeter/extractor/TestBoundaryExtractor.java 97.88% <0%> (ø) 17% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286a89e...29c3f06. Read the comment docs.

@asfgit asfgit closed this in 0ccd361 Dec 7, 2017

@ham1 ham1 deleted the ham1:menu_bar branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment