-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Checkstyle: LineLength max 165, AnonInnerLength 45 and other whitespace checks #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #358 +/- ##
============================================
- Coverage 58.37% 58.37% -0.01%
- Complexity 10316 10317 +1
============================================
Files 1170 1170
Lines 74347 74411 +64
Branches 7324 7326 +2
============================================
+ Hits 43399 43435 +36
- Misses 28421 28451 +30
+ Partials 2527 2525 -2
Continue to review full report at Codecov.
|
Hi @ham1 , Would it be possible to rebase your PR and split it into at max 10 files ? Also if possible, try to make the PR really only touch what it pretends to. Regards |
Sorry, yeah I see how this is difficult to review. I tend to change things as I see them in the file I'm editing. I will revise and split it up into one type of change per commit, is that ok? It might be more than 10 files but should be easier to review. |
…ce checks Also removed some unnecessary StringBuilders
Part of #358 on github. Based on contribution by Graham Russell (graham at ham1.co.uk) git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823897 13f79535-47bb-0310-9956-ffa450edef68
plus some other whitespace policing. Part of #358 on github. Based on contribution by Graham Russell (graham at ham1.co.uk) git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823898 13f79535-47bb-0310-9956-ffa450edef68
Part of #358 on github. Based on contribution by Graham Russell (graham at ham1.co.uk) git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823899 13f79535-47bb-0310-9956-ffa450edef68
Part of #358 on github. Based on contribution by Graham Russell (graham at ham1.co.uk) git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823900 13f79535-47bb-0310-9956-ffa450edef68
Part of #358 on github. Based on contribution by Graham Russell (graham at ham1.co.uk) git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823901 13f79535-47bb-0310-9956-ffa450edef68
Part of #358 on github. Based on contribution by Graham Russell (graham at ham1.co.uk) git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823903 13f79535-47bb-0310-9956-ffa450edef68
Part of #358 on github. Based on contribution by Graham Russell (graham at ham1.co.uk) git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823905 13f79535-47bb-0310-9956-ffa450edef68
Part of #358 on github. Based on contribution by Graham Russell (graham at ham1.co.uk) git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823906 13f79535-47bb-0310-9956-ffa450edef68
Part of #358 on github. Based on contribution by Graham Russell (graham at ham1.co.uk) git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823908 13f79535-47bb-0310-9956-ffa450edef68
Part of #358 on github. Based on contribution by Graham Russell (graham at ham1.co.uk) git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823932 13f79535-47bb-0310-9956-ffa450edef68
Part of #358 on github. Based on contribution by Graham Russell (graham at ham1.co.uk) git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823940 13f79535-47bb-0310-9956-ffa450edef68
Preparation to get line length down to 160 chars. In preparation for #358 on github git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823944 13f79535-47bb-0310-9956-ffa450edef68
As a bonus re-format a small if clause. Preparation for #358 on github. git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823947 13f79535-47bb-0310-9956-ffa450edef68
Preparation for #358 on github. git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823948 13f79535-47bb-0310-9956-ffa450edef68
Part of #358 on github. Based on contribution by Graham Russell (graham at ham1.co.uk) git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823949 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823950 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823951 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823954 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823955 13f79535-47bb-0310-9956-ffa450edef68
Also removed some unnecessary
StringBuilder
sHow Has This Been Tested?
ant checkstyle test