Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanded Checkstyle to files in src and test; fixed newly checked files #365

Closed
wants to merge 1 commit into from
Closed

Expanded Checkstyle to files in src and test; fixed newly checked files #365

wants to merge 1 commit into from

Conversation

ham1
Copy link
Contributor

@ham1 ham1 commented Dec 23, 2017 •
edited

Description

Added test to the files being checked.

Motivation and Context

Felix and Philippe found some test files without the headers, this fixes Checkstyle not picking that up.

How Has This Been Tested?

ant checkstyle

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

@codecov-io
Copy link

Codecov Report

Merging #365 into trunk will increase coverage by <.01%.
The diff coverage is 60.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk     #365      +/-   ##
============================================
+ Coverage     58.35%   58.35%   +<.01%     
- Complexity    10288    10290       +2     
============================================
  Files          1164     1164              
  Lines         74127    74135       +8     
  Branches       7298     7298              
============================================
+ Hits          43254    43263       +9     
  Misses        28359    28359              
+ Partials       2514     2513       -1
Impacted Files Coverage Δ Complexity Δ
...mpler/TestHTTPSamplersAgainstHttpMirrorServer.java 89.75% <ø> (ø) 80 <0> (ø) ⬇️
...g/apache/jmeter/assertions/SMIMEAssertionTest.java 100% <ø> (ø) 9 <0> (ø) ⬇️
...er/protocol/http/control/TestHTTPMirrorThread.java 90% <ø> (ø) 26 <0> (ø) ⬇️
...apache/jmeter/functions/TestTimeShiftFunction.java 89.32% <ø> (ø) 12 <0> (ø) ⬇️
...pache/jmeter/assertions/ResponseAssertionTest.java 99.03% <ø> (ø) 14 <0> (ø) ⬇️
...t/src/org/apache/jmeter/functions/PackageTest.java 91.63% <ø> (ø) 25 <0> (ø) ⬇️
...rg/apache/jmeter/visualizers/TestRenderAsJson.java 100% <ø> (ø) 10 <0> (ø) ⬇️
.../org/apache/jmeter/functions/ChangeCaseSpec.groovy 100% <ø> (ø) 1 <0> (ø) ⬇️
...che/jmeter/protocol/http/config/UrlConfigTest.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...est/src/org/apache/jorphan/util/TestConverter.java 100% <ø> (ø) 11 <0> (ø) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 998b330...08615ed. Read the comment docs.

asfgit pushed a commit that referenced this pull request Feb 11, 2018
@FSchumacher
Organize imports.
9257dd8 
In preparation for #365 on github. Contributed by Graham Russell (graham at ham1.co.uk)


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823865 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Feb 11, 2018
@FSchumacher
Remove unnecessary parentheses
edf2ed4 
In preparation for #365 on github. Contributed by Graham Russell (graham at ham1.co.uk)


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823866 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Feb 11, 2018
@FSchumacher
Correct use of array type style
0c59067 
In preparation for #365 on github. Contributed by Graham Russell (graham at ham1.co.uk)


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823867 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Feb 11, 2018
@FSchumacher
Convert tabs to spaces
0a37e9c 
In preparation for #365 on github. Contributed by Graham Russell (graham at ham1.co.uk)


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823868 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Feb 11, 2018
@FSchumacher
Use one statement per line
fd797b7 
In preparation for #365 on github. Contributed by Graham Russell (graham at ham1.co.uk)


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823869 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Feb 11, 2018
@FSchumacher
Don't use multiple variable declarations
6facf67 
In preparation for #365 on github. Contributed by Graham Russell (graham at ham1.co.uk)


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823870 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Feb 11, 2018
@FSchumacher
Remove unnecessary empty lines
277f897 
In preparation for #365 on github. Contributed by Graham Russell (graham at ham1.co.uk)


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823871 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Feb 11, 2018
@FSchumacher
Set eol-style to native
0552f21 
In preparation for #365 on github.


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823875 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Feb 11, 2018
@FSchumacher
Reduce nested try depth
e448449 
In preparation for #365 on github.


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823880 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Feb 11, 2018
@FSchumacher
Add newline at end of file
25f2a4c 
In preparation for #365 on github. Contributed by Graham Russell (graham at ham1.co.uk)


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823881 13f79535-47bb-0310-9956-ffa450edef68
@asfgit asfgit closed this in 5593760 Feb 11, 2018
@FSchumacher
Copy link
Contributor

Thanks for your contribution.

@ham1 ham1 deleted the increase_checkstyle_file_coverage branch February 11, 2018 19:34
@ham1
Copy link
Contributor Author

ham1 commented Feb 11, 2018

Thanks for committing!

asfgit pushed a commit that referenced this pull request Feb 12, 2018
@FSchumacher
No need to explicitly create an array for the arguments.
ed15c5b 
This is the last part of the Checkstyle pull requests #358, #365, #366 and #375.
It closes #366 and #358 on github.

Based on contribution by Graham Russell (graham at ham1.co.uk) 


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1823957 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ham1 @codecov-io @FSchumacher