Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSet max line length to 160 (eventual target 120). #366
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
codecov-io
Dec 23, 2017
Codecov Report
Merging #366 into trunk will increase coverage by
<.01%.
The diff coverage is47.08%.
@@ Coverage Diff @@
## trunk #366 +/- ##
============================================
+ Coverage 58.37% 58.38% +<.01%
+ Complexity 10316 10315 -1
============================================
Files 1170 1170
Lines 74347 74437 +90
Branches 7324 7331 +7
============================================
+ Hits 43399 43458 +59
- Misses 28421 28453 +32
+ Partials 2527 2526 -1| Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| .../backend/graphite/PickleGraphiteMetricsSender.java | 0% <ø> (ø) |
0 <0> (ø) |
|
| .../org/apache/jmeter/report/core/SampleMetadata.java | 26.08% <ø> (ø) |
8 <0> (ø) |
|
| ...jmeter/protocol/http/util/accesslog/LogFilter.java | 81.3% <ø> (ø) |
35 <0> (ø) |
|
| ...er/protocol/http/proxy/AbstractSamplerCreator.java | 59.37% <ø> (ø) |
6 <0> (ø) |
|
| ...rotocol/smtp/sampler/protocol/SendMailCommand.java | 0% <ø> (ø) |
0 <0> (ø) |
|
| ...rg/apache/jmeter/util/keystore/JmeterKeyStore.java | 19.54% <ø> (ø) |
4 <0> (ø) |
|
| ...apache/jmeter/control/gui/ModuleControllerGui.java | 31.25% <ø> (ø) |
8 <0> (ø) |
|
| ...ts/org/apache/jmeter/visualizers/RenderAsJSON.java | 60% <ø> (ø) |
12 <0> (ø) |
|
| ...g/apache/jmeter/samplers/AbstractSampleSender.java | 80% <ø> (ø) |
2 <0> (ø) |
|
| ...protocol/http/sampler/LazySchemeSocketFactory.java | 66.66% <ø> (ø) |
5 <0> (ø) |
|
| ... and 33 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 33f09a9...688ce70. Read the comment docs.
codecov-io
commented
Dec 23, 2017
•
Codecov Report
@@ Coverage Diff @@
## trunk #366 +/- ##
============================================
+ Coverage 58.37% 58.38% +<.01%
+ Complexity 10316 10315 -1
============================================
Files 1170 1170
Lines 74347 74437 +90
Branches 7324 7331 +7
============================================
+ Hits 43399 43458 +59
- Misses 28421 28453 +32
+ Partials 2527 2526 -1
Continue to review full report at Codecov.
|
ham1
added some commits
Dec 23, 2017
asfgit
closed this
in
ed15c5b
Feb 12, 2018
ham1
deleted the
ham1:max_line_length
branch
Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ham1 commentedDec 23, 2017
Description
Added new checkstyle rule for max line length of 160; with the view to, eventually, make it around 120. I will create another PR with the rest of the changes from #358 once this is merged as it should make merging slightly easier.
Hopefully reducing the scope and splitting this into commits that each change a separate thing will help merging - let me know if it's too much and I could split further if required.
Motivation and Context
This PR will prevent any extra long lines and extra long anonymous inner classes being accidentally added.
Checklist: