Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds parameter supports for RMI keystore creation scripts #386

Conversation

@loganmzz
Copy link

@loganmzz loganmzz commented May 23, 2018

Helps to integrate script into non-interactive process.

Description

Pass script parameters to keytool command

N/A

Motivation and Context

It helps caller to customize key creation and also enable to integrate script into non-interactive process.

How Has This Been Tested?

${JMETER_HOME}/bin/create-rmi-keystore.sh -dname 'o=Foobar' -keypass 'f0o84R!'

%JMETER_HOME%\bin\create-rmi-keystore.bat -dname 'o=Foobar' -keypass 'f0o84R!'

  • Linux: Debian 8 (Docker) + Open JDK 8u111
  • Windows: 7 Pro + Oracle JDK 8u152

N/A

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
Helps to integrate script into non-interactive process.
@asfgit asfgit closed this in d33bd0b May 26, 2018
@FSchumacher
Copy link
Contributor

@FSchumacher FSchumacher commented May 26, 2018

Thanks for your contribution.
Would you care to update the docs for the changes and create a new pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.