New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds parameter supports for RMI keystore creation scripts #386

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@loganmzz

loganmzz commented May 23, 2018

Helps to integrate script into non-interactive process.

Description

Pass script parameters to keytool command

N/A

Motivation and Context

It helps caller to customize key creation and also enable to integrate script into non-interactive process.

How Has This Been Tested?

${JMETER_HOME}/bin/create-rmi-keystore.sh -dname 'o=Foobar' -keypass 'f0o84R!'

%JMETER_HOME%\bin\create-rmi-keystore.bat -dname 'o=Foobar' -keypass 'f0o84R!'

  • Linux: Debian 8 (Docker) + Open JDK 8u111
  • Windows: 7 Pro + Oracle JDK 8u152

N/A

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
Logan Mauzaize (T524467)
Adds parameter supports for RMI keystore creation scripts
Helps to integrate script into non-interactive process.

@asfgit asfgit closed this in d33bd0b May 26, 2018

@FSchumacher

This comment has been minimized.

Show comment
Hide comment
@FSchumacher

FSchumacher May 26, 2018

Contributor

Thanks for your contribution.
Would you care to update the docs for the changes and create a new pull request :)

Contributor

FSchumacher commented May 26, 2018

Thanks for your contribution.
Would you care to update the docs for the changes and create a new pull request :)

ham1 added a commit to ham1/jmeter that referenced this pull request Jun 20, 2018

Add parameter support for RMI keystore creation scripts.
Contributed by Logan Mauzaize (t524467 at airfrance.fr). Closes apache#386 on github


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1832303 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment