Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delegation for SPNEGO back to JMeter #387

Closed
wants to merge 2 commits into from

Conversation

@FSchumacher
Copy link
Contributor

@FSchumacher FSchumacher commented Jun 7, 2018

Description

Newer httpclient versions (at least in the 4.x branch) have dropped the support for delegation of kerberos tickets over SPNEGO. This patch brings back the support to delegation back to JMeter.

Motivation and Context

Older versions of JMeter always tried to get forwardable tickets when using SPNEGO. As I need this functionality for a service, I would like to have the forwarding back. As the default forwarding could be seen critical from a security standpoint, the patch disables it by default. It can be enabled by a system property.

How Has This Been Tested?

Tested it on a service that depends on delegation of tickets.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue) (At least I see this as a regression)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
@pmouawad
Copy link
Contributor

@pmouawad pmouawad commented Jun 8, 2018

Thanks for PR.
Just wondering, why do we use httpcomponents package ?

  • org.apache.http.impl.auth.DelegatingKerberosScheme
  • org.apache.http.impl.auth.DelegatingSPNegoScheme

Thanks

@FSchumacher
Copy link
Contributor Author

@FSchumacher FSchumacher commented Jun 8, 2018

I thought I hat to overwrite the method createGSSContext, which is only possible on a subclass in the same package. I changed it now explicitly to call another method and placed the classes in JMeter's package namespace. Will check on Monday, if it is still working.

@pmouawad
Copy link
Contributor

@pmouawad pmouawad commented Jun 8, 2018

Thanks Felix

@pmouawad
Copy link
Contributor

@pmouawad pmouawad commented Jun 15, 2018

Hi Felix,
Did you have time to check the changes are working ?
If yes, +1 for committing it.

@asfgit asfgit closed this in 2a3694f Jun 16, 2018
asfgit pushed a commit that referenced this pull request Jun 16, 2018
Follow up to r1833637

Bugzilla Id: 62462
Relates to #387 on github



git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1833640 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.