Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display an info message, when no JavaFX is found and RenderInBrowser … #408

Closed
wants to merge 1 commit into from
Closed

Display an info message, when no JavaFX is found and RenderInBrowser … #408

wants to merge 1 commit into from

Conversation

@FSchumacher
Copy link
Contributor

@FSchumacher FSchumacher commented Oct 13, 2018

…is used

Description

Currently we will log a full exception stack trace in warning level, when no
JavaFX was found and RenderInBrowser is initialized.

Reduce the log level to info and display a short message that the user should
install JavaFX in their Java environment, if they want to use the renderer.

Motivation and Context

The user is probably scared when an exception stack trace is shown in their log file. This change should help the user to take the needed steps more easily.

How Has This Been Tested?

Tested through GUI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
…is used

Currently we will log a full exception stack trace in warning leve, when no
JavaFX was found and RenderInBrowser is initialized.

Reduce the log level to info and display a short message that the user should
install JavaFX in their Java environment, if they want to use the renderer.
@codecov-io
Copy link

@codecov-io codecov-io commented Oct 13, 2018

Codecov Report

Merging #408 into trunk will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk     #408      +/-   ##
============================================
+ Coverage     58.58%   58.58%   +<.01%     
- Complexity    10616    10618       +2     
============================================
  Files          1193     1193              
  Lines         75957    75961       +4     
  Branches       7343     7344       +1     
============================================
+ Hits          44499    44505       +6     
  Misses        28953    28953              
+ Partials       2505     2503       -2
Impacted Files Coverage Δ Complexity Δ
.../jmeter/visualizers/ViewResultsFullVisualizer.java 38% <0%> (-0.57%) 15 <0> (ø)
...re/org/apache/jmeter/engine/DistributedRunner.java 85.71% <0%> (+3.36%) 32% <0%> (+1%) ⬆️
...s/org/apache/jmeter/timers/PoissonRandomTimer.java 78.37% <0%> (+5.4%) 10% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b15fab0...002d427. Read the comment docs.

@pmouawad
Copy link
Contributor

@pmouawad pmouawad commented Oct 13, 2018

+1

Should you test «.javafx. » instead of only javafx?

Thanks

@asfgit asfgit closed this in 36bc5f8 Oct 14, 2018
@FSchumacher
Copy link
Contributor Author

@FSchumacher FSchumacher commented Oct 14, 2018

The message from a ClassNotFoundException is checked for javafx. I think it is safe to assume that any message on that kind of error hints to a missing JavaFX installation, when it contains the string javafx.

StorDm pushed a commit to etnetera/jmeter that referenced this issue Jan 7, 2021
This will happen when JavaFX is not found while looking
for the RenderInBrowser component.

Closes apache#408 on github


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1843812 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 36bc5f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants