-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Get rid of deprecated new instance calls #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
FSchumacher
wants to merge
52
commits into
apache:trunk
from
FSchumacher:get-rid-of-deprecated-newInstance-calls
Closed
Get rid of deprecated new instance calls #435
FSchumacher
wants to merge
52
commits into
apache:trunk
from
FSchumacher:get-rid-of-deprecated-newInstance-calls
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the thrown exceptions of the createThinkTime method, while we are here
With the introduction of varargs this can be written simpler. We don't have to construct arrays here anymore.
asfgit
pushed a commit
that referenced
this pull request
Dec 2, 2018
Part of #435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847986 13f79535-47bb-0310-9956-ffa450edef68
asfgit
pushed a commit
that referenced
this pull request
Dec 2, 2018
Part of #435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847987 13f79535-47bb-0310-9956-ffa450edef68
asfgit
pushed a commit
that referenced
this pull request
Dec 2, 2018
Part of #435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847989 13f79535-47bb-0310-9956-ffa450edef68
asfgit
pushed a commit
that referenced
this pull request
Dec 2, 2018
Part of #435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847990 13f79535-47bb-0310-9956-ffa450edef68
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847959 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 0747ca7
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847960 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 5470c38
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847961 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: d08e486
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847964 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 431108b
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847965 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 4f844ea
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Newer java versions have changed the method signatures to varargs. Use those varargs. Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847966 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: b1c9cf0
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847969 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 23d608a
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847972 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 232583a
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847973 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 8993041
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847974 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 1744f9b
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847975 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 569c141
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847976 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: b5f7acb
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847977 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: cac54e6
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847978 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: cb56c49
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847979 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 970babc
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847980 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 741468c
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847981 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 53eefd1
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847982 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 368c482
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847984 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 4e894b3
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847985 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 5835c0f
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847986 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: dc18430
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847987 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: dee641b
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847989 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: faf53bb
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Part of apache#435 and Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847990 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 7598524
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Closes apache#435 Bugzilla Id: 62972 git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847991 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: dcb7579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This basically is an update to #431
Get rid of calls to
Class#newInstance()by replacing them withClass#getDeclaredConstructor()#newInstance()And while I edited the classes I cleaned them up a bit, when eclipse showed warnings. I think those snippets should be committed separately, but I left them in here, so that they can be discussed if necessary.
Motivation and Context
Java 9 deprecates Class#newInstance().
How Has This Been Tested?
Tests should run when github merges this for testing.
Screenshots (if appropriate):
Types of changes
Checklist: