Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Unit tests readability and use of Spock #446

Closed
wants to merge 7 commits into from

Conversation

@ham1
Copy link
Contributor

commented Feb 23, 2019

Description

Improve the readability and reduced complexity of many Spock tests.

Sorry for the large-ish PR but I've tried to make the commits reasonably small and distinct.

How Has This Been Tested?

ant test-headless -Drmi_force_localhost=true

@codecov-io

This comment has been minimized.

Copy link

commented Feb 23, 2019

Codecov Report

Merging #446 into trunk will increase coverage by <.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk     #446      +/-   ##
============================================
+ Coverage     58.58%   58.59%   +<.01%     
- Complexity    10786    10787       +1     
============================================
  Files          1206     1206              
  Lines         77258    77253       -5     
  Branches       7464     7460       -4     
============================================
- Hits          45264    45263       -1     
  Misses        29459    29459              
+ Partials       2535     2531       -4
Impacted Files Coverage Δ Complexity Δ
...c/org/apache/jmeter/engine/util/PackageSpec.groovy 97.43% <ø> (ø) 6 <0> (ø) ⬇️
...pache/jmeter/assertions/MD5HexAssertionSpec.groovy 78.26% <ø> (ø) 6 <0> (ø) ⬇️
...t/processor/Top5ErrorsBySamplerConsumerSpec.groovy 93.1% <ø> (ø) 5 <0> (ø) ⬇️
...rc/org/apache/jmeter/junit/spock/JMeterSpec.groovy 9.09% <ø> (ø) 3 <0> (ø) ⬇️
...meter/protocol/jdbc/sampler/JDBCSamplerSpec.groovy 100% <ø> (ø) 7 <0> (ø) ⬇️
...c/org/apache/jmeter/services/FileServerSpec.groovy 91.3% <0%> (ø) 21 <0> (ø) ⬇️
...che/jmeter/control/ThroughputControllerSpec.groovy 96.19% <100%> (ø) 11 <2> (ø) ⬇️
.../report/processor/FieldSampleComparatorSpec.groovy 100% <100%> (ø) 2 <2> (?)
...t/src/org/apache/jorphan/util/ConverterSpec.groovy 100% <100%> (ø) 7 <6> (ø) ⬇️
.../report/processor/Top5ErrorsSummaryDataSpec.groovy 100% <100%> (ø) 6 <3> (ø) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479d95e...f17673b. Read the comment docs.

@asfgit asfgit closed this in 46363a0 Feb 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.