Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract graph consumer improvements #450

Closed
wants to merge 4 commits into from

Conversation

@ham1
Copy link
Contributor

commented Feb 25, 2019

Description

  • Formatting for readability
  • Renamed misleading variable/methods revertKeysAndValues -> invertKeysAndValues
  • Removed pointless JavaDoc which clutters the class

Motivation and Context

More unit testing and easier to understand code

How Has This Been Tested?

ant clean test-headless -Drmi_force_localhost=true

@codecov-io

This comment has been minimized.

Copy link

commented Feb 25, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (trunk@be3271f). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             trunk    #450   +/-   ##
=======================================
  Coverage         ?   58.7%           
  Complexity       ?   10815           
=======================================
  Files            ?    1209           
  Lines            ?   77330           
  Branches         ?    7464           
=======================================
  Hits             ?   45397           
  Misses           ?   29393           
  Partials         ?    2540
Impacted Files Coverage Δ Complexity Δ
.../report/processor/graph/AbstractGraphConsumer.java 3.13% <0%> (ø) 3 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be3271f...d557dce. Read the comment docs.

@asfgit asfgit closed this in 0255e9a Feb 26, 2019

@ham1 ham1 deleted the ham1:abstract-graph-consumer-improvements branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.