Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Typos #480

Closed
wants to merge 1 commit into from
Closed

Fix: Typos #480

wants to merge 1 commit into from

Conversation

@Mithrandir0407
Copy link
Contributor

@Mithrandir0407 Mithrandir0407 commented Aug 22, 2019

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
@@ -263,7 +263,7 @@ public void triggerEndOfLoop() {
// See Bug 56811
// triggerEndOfLoop is called when error occurs to end Main Loop
// in this case normal workflow doesn't happen, so we need
// to notify the childs of TransactionController and
// to notify the child of TransactionController and
Copy link

@ljacqu ljacqu Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably meant children here

Copy link
Contributor Author

@Mithrandir0407 Mithrandir0407 Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you're right :)

@@ -361,7 +361,7 @@ public boolean stopThread(String threadName, boolean now) {
}

/**
* Hard Stop JMeterThread thrd and interrupt JVM Thread if interrupt is true
* Hard Stop JMeterThread third and interrupt JVM Thread if interrupt is true
Copy link
Contributor

@FSchumacher FSchumacher Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably thread and not third. We could probably get rid of thr*d here at all.

asfgit pushed a commit that referenced this issue Aug 25, 2019
Part of #480 on github
asfgit pushed a commit that referenced this issue Aug 25, 2019
Part of #480 on github
asfgit pushed a commit that referenced this issue Aug 25, 2019
asfgit pushed a commit that referenced this issue Aug 25, 2019
Part of #480 on github
asfgit pushed a commit that referenced this issue Aug 25, 2019
@asfgit asfgit closed this in c1a198f Aug 25, 2019
@FSchumacher
Copy link
Contributor

@FSchumacher FSchumacher commented Aug 25, 2019

Thanks for the pull request. It is always nice to know that someone looks at the code and cares enough to send in changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants