Code refactor 1 #482
Closed
Code refactor 1 #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Replace label_resouce by label_resource + Replace resouces by resources + Replace resourcename by resourceName
…figuredDataSource()
FSchumacher
reviewed
Aug 29, 2019
Contributor
FSchumacher
left a comment
FSchumacher
left a comment
There was a problem hiding this comment.
Thanks -- again -- for the patches. I will commit them with the slight changes I indicated at the lines.
| SampleResult result = event.getResult(); | ||
| for (SampleResult subResult : result.getSubResults()) { | ||
| savee = resultToDelimitedString(event, subResult, saveConfiguration, delimiter); | ||
| out.println(savee); |
Contributor
There was a problem hiding this comment.
I am not sure if savee meant the thing that is to be saved, so I will rename the variable to formattedResult. It seems to me, that it is exactly that.
| /** | ||
| * | ||
| * @param label_resouce text resource name for group label | ||
| * @param label_resource text resource name for group label |
Contributor
There was a problem hiding this comment.
Java convention for naming parameters is to use camel case, so I will change it.
asfgit
pushed a commit
that referenced
this pull request
Aug 29, 2019
…erProperties Part of #482 on github
asfgit
pushed a commit
that referenced
this pull request
Aug 29, 2019
…eterProperties Part of #482 on github
asfgit
pushed a commit
that referenced
this pull request
Aug 29, 2019
+ Replace label_resouce by label_resource + Replace resouces by resources + Replace resourcename by resourceName Part of #482 on github
asfgit
pushed a commit
that referenced
this pull request
Aug 29, 2019
…uredDataSource() Part of #482 on github
asfgit
pushed a commit
that referenced
this pull request
Aug 29, 2019
The old name was savee, which might have been an error, so try to be clearer about the name. It is the formatted result. Part of #482 on github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: