Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactor 1 #482

Closed
wants to merge 9 commits into from

Conversation

@Mithrandir0407
Copy link
Contributor

Mithrandir0407 commented Aug 26, 2019

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
Copy link
Contributor

FSchumacher left a comment

Thanks -- again -- for the patches. I will commit them with the slight changes I indicated at the lines.


if(saveConfiguration.saveSubresults()) {
SampleResult result = event.getResult();
for (SampleResult subResult : result.getSubResults()) {
savee = resultToDelimitedString(event, subResult, saveConfiguration, delimiter);
out.println(savee);

This comment has been minimized.

Copy link
@FSchumacher

FSchumacher Aug 29, 2019

Contributor

I am not sure if savee meant the thing that is to be saved, so I will rename the variable to formattedResult. It seems to me, that it is exactly that.

@@ -56,12 +56,12 @@

/**
*
* @param label_resouce text resource name for group label
* @param label_resource text resource name for group label

This comment has been minimized.

Copy link
@FSchumacher

FSchumacher Aug 29, 2019

Contributor

Java convention for naming parameters is to use camel case, so I will change it.

asfgit pushed a commit that referenced this pull request Aug 29, 2019
Part of #482 on github
asfgit pushed a commit that referenced this pull request Aug 29, 2019
asfgit pushed a commit that referenced this pull request Aug 29, 2019
asfgit pushed a commit that referenced this pull request Aug 29, 2019
asfgit pushed a commit that referenced this pull request Aug 29, 2019
+ Replace label_resouce by label_resource
+ Replace resouces by resources
+ Replace resourcename by resourceName

Part of #482 on github
asfgit pushed a commit that referenced this pull request Aug 29, 2019
asfgit pushed a commit that referenced this pull request Aug 29, 2019
asfgit pushed a commit that referenced this pull request Aug 29, 2019
asfgit pushed a commit that referenced this pull request Aug 29, 2019
asfgit pushed a commit that referenced this pull request Aug 29, 2019
The old name was savee, which might have been
an error, so try to be clearer about the
name. It is the formatted result.

Part of #482 on github
asfgit pushed a commit that referenced this pull request Aug 29, 2019
@asfgit asfgit closed this in 81ba16c Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.