Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the startup time: skip test plan UI initialization #573

Merged
merged 1 commit into from Mar 26, 2020

Conversation

vlsi
Copy link
Collaborator

@vlsi vlsi commented Mar 24, 2020

On my machine menu initialization takes 2-3 seconds (2.6GHz, SSD, fully cached).
Most of the cases the time is spent in creating Swing components, however, that work is not needed to get the label for the menu.

Even though the proper approach would be to split metadata from the UI components, I think it is fine to have an intermediate solution.
Note: TestBeanGui does not initialize UI elements, however, full bean metadata initialization still takes time (e.g. JSR223 elements query ScriptEngine for the list of available languages)

@pmouawad
Copy link
Contributor

@pmouawad pmouawad commented Mar 24, 2020

Hi @vlsi ,
It looks good to me.
But can you clarify the gain on your machine ?
It takes now 2-3 seconds ? vs how much before ?

Thanks

@vlsi
Copy link
Collaborator Author

@vlsi vlsi commented Mar 24, 2020

It takes now 2-3 seconds ?

@pmouawad , it was 2-3 seconds (before fix), and now it is 0.1sec (after fix)
Splash screen disappears almost at the same time JMeter window opens.

JMeter used to initialize all the components at the startup even in case
the element was never used.

This commit adds a shortcut for the well-known in-core components.

User-visible outcome is the spashscreen no longer gets stuck
for 2 seconds at 100%
@vlsi vlsi merged commit b47c658 into apache:master Mar 26, 2020
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants