Add KeyStroke for start_no_timers (Start no pauses: CRTL+SHIFT+n) #5792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also this page needs to be updated afterwards: |
FSchumacher
reviewed
Apr 23, 2023
| @@ -72,6 +72,7 @@ private static int getMenuShortcutKeyMask() { | |||
| public static final KeyStroke OPEN = KeyStroke.getKeyStroke(KeyEvent.VK_O, CONTROL_MASK); | |||
| public static final KeyStroke EXIT = KeyStroke.getKeyStroke(KeyEvent.VK_Q, CONTROL_MASK); | |||
| public static final KeyStroke ACTION_START = KeyStroke.getKeyStroke(KeyEvent.VK_R, CONTROL_MASK); | |||
| public static final KeyStroke ACTION_START_NO_PAUSE = KeyStroke.getKeyStroke(KeyEvent.VK_N, CONTROL_MASK | InputEvent.SHIFT_DOWN_MASK); | |||
There was a problem hiding this comment.
Ctrl+Shift+N feels a bit like a command to create something new. But as the menu shortcut uses n already, this seems to be a natural choice here.
|
Why close the PR? they aren't merge into main source? |
|
@milamberspace yes, you are absolutely right! |
milamberspace
changed the title
asfgit
pushed a commit
that referenced
this pull request
Apr 24, 2023
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an additional KeyStroke to Start a local test, skipping the Timers.
Motivation and Context
In our daily doing we setup load tests, using Timers.
For faster test preparation, we want to skip timers.
How Has This Been Tested?
./gradlew createDist
./bin/jmeter -t Testplan-with-pauses.jmx
Execute Testplan with Crtl-R
Execute Testplan with Ctrl-Shift-N
Types of changes