Update groovy 3

[FSchumacher]

Description

Update Groovy from 2.4 to 3.0 and use the split up jars instead of the groovy-all one.

Note The test framework spock – that we use in our test base – currently supports Groovy 3.0 only in the 2.0 branch, which is not officially released, yet.

I am not sure, whether this PR should be merged before the next release.

Motivation and Context

Groovy 3.0 is the current development line of Groovy and will support newer Java versions better.

How Has This Been Tested?

./gradlew test ran successfully on my machine

Screenshots (if appropriate):

Types of changes

• New feature (non-breaking change which adds functionality)
  Using Groovy 3.x should be in most cases a drop in replacement for Groovy 2.4. See https://groovy-lang.org/releasenotes/groovy-3.0.html for more information

Checklist:

• My code follows the code style of this project.
• I have updated the documentation accordingly.

[vlsi]

Can you please use org.codehaus.groovy:groovy-bom instead?

Suggested change

	apiv("org.codehaus.groovy:groovy", "groovy")
	apiv("org.codehaus.groovy:groovy-datetime", "groovy")
	apiv("org.codehaus.groovy:groovy-jmx", "groovy")
	apiv("org.codehaus.groovy:groovy-json", "groovy")
	apiv("org.codehaus.groovy:groovy-jsr223", "groovy")
	apiv("org.codehaus.groovy:groovy-sql", "groovy")
	apiv("org.codehaus.groovy:groovy-templates", "groovy")
	api(platform("org.codehaus.groovy:groovy-bom:${"groovy".v}"))

[FSchumacher]

That looks really nice, but when I try it out, it gives me the following error:

Build jmeter FAILURE reason:                                
    org.gradle.internal.exceptions.LocationAwareException: Build file '/home/felix/Developer/fschumacher-jmeter/src/bom/build.gradle.kts' line: 90
    Cannot convert the provided notation to an object of type DependencyConstraint: DefaultExternalModuleDependency{group='org.codehaus.groovy', name='groovy-bom', version='3.0.3', configuration='default'}.
    The following types/formats are supported:
      - Instances of DependencyConstraint.
      - String or CharSequence values, for example 'org.gradle:gradle-core:1.0'.
      - Maps, for example [group: 'org.gradle', name: 'gradle-core', version: '1.0'].
      - Projects, for example project(':some:project:path').
      - Instances of ProjectDependency.
    
    Comprehensive documentation on dependency notations is available in DSL reference for DependencyHandler type.
        Caused by: org.gradle.internal.typeconversion.UnsupportedNotationException: Cannot convert the provided notation to an object of type DependencyConstraint: DefaultExternalModuleDependency{group='org.codehaus.groovy', name='groovy-bom', version='3.0.3', configuration='default'}.
        The following types/formats are supported:
          - Instances of DependencyConstraint.
          - String or CharSequence values, for example 'org.gradle:gradle-core:1.0'.
          - Maps, for example [group: 'org.gradle', name: 'gradle-core', version: '1.0'].
          - Projects, for example project(':some:project:path').
          - Instances of ProjectDependency.

[vlsi]

Oh,

https://docs.gradle.org/current/userguide/java_platform_plugin.html#sec:java_platform_bom_import

So there should be the following before dependencies

javaPlatform {
    allowDependencies()
}

and api(platform(...)) should come in the dependencies section rather than dependencies { constraints { ... }}.

Can you please try that? (move api(platform before (constraints) {...)

[FSchumacher]

That works. Thanks for the hint.

[vlsi]

Just in case: I think 2.0-M2-groovy-3.0 is OK Spock version to use.
I don't think we bend Spock to the extreme, so I don't think we would suffer from further Spock upgrades.

[pmouawad]

I would just add in release notes in section breaking change a note about this.

Thanks for PR