Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTML parser to pick up preload attribute for rel #5947

Closed

Conversation

matthewt-assurity
Copy link
Contributor

@matthewt-assurity matthewt-assurity commented May 29, 2023

Description

Updated JMeter HTML parsers to pick up on the preload value for the rel attribute in <link> tags.

A constant has been added to HTMLParser.java for the preload value. The parser implementation classes have been updated to use this constant.

Motivation and Context

During a project we found some embedded resource files that were not being downloaded by default. To address this in the meantime we have used the parallel sampler extension. We found that the problem was the preload value wasn't being picked up as a valid value in the JMeter HTML parsers, so I am proposing that this becomes part of the HTML parsers.

I am unaware of any open issue for this.

How Has This Been Tested?

./gradlew runGui has been run, and a simple test hitting an HTML page with rel=preload attributes was run.

./gradlew check has been run and passes.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

@matthewt-assurity
Copy link
Contributor Author

This is my first time contributing to JMeter, is there any documentation that should be updated for this change?

@vlsi vlsi added this to the 5.6 milestone Jun 1, 2023
@vlsi
Copy link
Collaborator

vlsi commented Jun 1, 2023

Do you think you could update https://github.com/apache/jmeter/blob/master/xdocs/changes.xml as well?
I think it is worth adding the improvement in the release notes.

@vlsi
Copy link
Collaborator

vlsi commented Jun 5, 2023

Merged in 6d6479b

@vlsi vlsi closed this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants