Migrate TestElement interface to Kotlin #5959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
force-pushed
the
testelement_kotlin
branch
2 times, most recently
from
c164460 to
d7c339d
Compare
vlsi
commented
Jun 2, 2023
Comment on lines
+252
to
+255
| /** | ||
| * Associates a name with this element. | ||
| */ | ||
| public var name: String? |
There was a problem hiding this comment.
I'm not sure if name should be nullable, however, I keep it for backward compatibility
…Kotlin Renaming the file first helps Git to track history better
It enables better control over nullability of the parameters and return types, and it enables declaring "operator fun get", and "operator fun set" so TestElements are easier to use in Kotlin.
…es that contain Kotlin code in src/main Java's Javadoc can't build documentation for Kotlin code, so we need something else. Dokka can create documentation for both Kotlin and Java. See https://kotlinlang.org/docs/dokka-introduction.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This a transparent migration of TestElement interface to Kotiln.
Motivation and Context
Kotlin enables better nullability which is good both for Kotlin (compilation fails if null is passed to a method not expecting null), and Java (Kotlin compiler generates
@NotNullannotations, so IDEs show when Java code does not handle nulls properly).Writing the interface in Kotlin enables the use of
operator fun get(property), andoperator fun set(property)so it enables better APIs for Kotlin code. See #5946 (comment)Checklist: