fix: AbstractTestElement#clone might produce non-identical clones if element constructor adds a non-default property value #5984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
changed the title
…element constructor adds a non-default property value Historically AbstractTestElement calls default constructor in order to create a clone. It might be that a constructor would add properties (e.g. LoopController, HeaderManager), so we might get invalid clones if the clone source _removes_ a property which was added in the constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically AbstractTestElement calls default constructor in order to create a clone. It might be that a constructor would add properties (e.g. LoopController, HeaderManager), so we might get invalid clones if the clone source removes a property which was added in the constructor.
An alternative approach would be using
super.clone(), however, it would be a significant change, so for now I suggest just removing "extra" properties that might be accidentally added in constructor.The visible effect was that
LoopControllerwas unequal after cloning if user removescontinueForeverproperty from theLoopController.