Make use of newer API for darklaf installation. #609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weisJ
force-pushed
the
darklaf_installation
branch
from
513f5a4 to
fb9a1e3
Compare
|
Thanks for the nice patch. |
ham1
pushed a commit
to ham1/jmeter
that referenced
this pull request
Sep 13, 2020
kkalinin
pushed a commit
to kkalinin/jmeter
that referenced
this pull request
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Newer versions of Darklaf offer to get a list of all available themes.
This PR replaces the manual setup of each Theme with iteration of said list.
Instead of checking the name of a Theme to determine whether it is dark make use of the
Theme#isDarkmethod.Darklaf version 2.4.4 fixes an issue, where viewing a
JListcould freeze the application. It also fixes misplaced tree hint popups (the popups that reveal the complete content of a tree cell if obstructed) on Windows.Checklist: