Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of newer API for darklaf installation. #609

wants to merge 2 commits into from


Copy link

@weisJ weisJ commented Aug 11, 2020


  • Newer versions of Darklaf offer to get a list of all available themes.
    This PR replaces the manual setup of each Theme with iteration of said list.

  • Instead of checking the name of a Theme to determine whether it is dark make use of the Theme#isDark method.

  • Darklaf version 2.4.4 fixes an issue, where viewing a JList could freeze the application. It also fixes misplaced tree hint popups (the popups that reveal the complete content of a tree cell if obstructed) on Windows.


  • My code follows the [code style][style-guide] of this project.
  • I have updated the documentation accordingly.

Copy link

Thanks for the nice patch.

ham1 pushed a commit to ham1/jmeter that referenced this pull request Sep 13, 2020
kkalinin pushed a commit to kkalinin/jmeter that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants