Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Darklaf properties. #613

wants to merge 2 commits into from


Copy link

@weisJ weisJ commented Aug 19, 2020


Provide documentation for some of the darklaf system properties.
This PR also updates darklaf to version 2.4.5 as there have been issues with focus highlighting of table cells.
Version 2.4.5 also provides the system property darklaf.unifiedMenuBar which toggles the unified menubar of darklaf.

Motivation and Context

Some people may be interested in using the custom window chrome feature of Darklaf (specifically on Windows).
Because some people dislike unified menubars the corresponding property also is exposed.

How Has This Been Tested?

I'm not entirely sure how to test changes to the documentation. I would appreciate if someone could guide me here on what to do.


  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

Ensure that 'darklaf.allowNativeCode' is set to 'true' if 'darklaf.decorations' is 'true'.
Copy link

@FSchumacher FSchumacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My test for docs (which mostly gone wrong) is to compile the docs with the corresponding Gradle task.
If the changes are bigger, I do take a look at the resulting pages with a browser.

@@ -95,10 +95,16 @@ private static MenuItem ofDarklafTheme(Theme theme) {
static {
if (System.getProperty("darklaf.decorations") == null) {
System.setProperty("darklaf.decorations", "false");
} else if ("true".equals(System.getProperty("darklaf.allowNativeCode"))) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you had a look at Boolean.getBoolean(name)? It should do the same as the "true".equals(System.getProperty(...).

@asfgit asfgit closed this in a146f6b Aug 20, 2020
Copy link

Thanks for the patch

ham1 pushed a commit to ham1/jmeter that referenced this pull request Sep 13, 2020
kkalinin pushed a commit to kkalinin/jmeter that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants